[GitHub] [spark] sqlwindspeaker commented on pull request #30686: [SPARK-33721][SQL] Support to use Hive build-in functions by configuration

[GitBox <gi...@apache.org>]

sqlwindspeaker commented on pull request #30686:
URL: https://github.com/apache/spark/pull/30686#issuecomment-742178694


   > There are too many differences, for example:
   > 
   > ```
   > hive> select timestamp '2020-06-01 24:00:00';
   > OK
   > 2020-06-02 00:00:00
   > Time taken: 0.034 seconds, Fetched: 1 row(s)
   > 
   > spark-sql> select to_timestamp('2020-06-01 24:00:00');
   > NULL
   > ```
   > 
   > Could we add these differences to http://spark.apache.org/docs/latest/sql-migration-guide.html#compatibility-with-apache-hive?
   
   Which version of hive is based on in this migration guide?
   
   I found some inconsistency not listed in the doc，but based on hive 1.x，so I guess this doc is based on hive 2.x？
   
   Since Spark 2.x is prebuilt with hive 1.x， meaning hive 1.x is still widely used，so I think we may note these inconsistency  in the doc？


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org