[GitHub] [logging-log4j2] ppkarwasz commented on a diff in pull request #1264: Add schema validation to changelogs

["ppkarwasz (via GitHub)" <gi...@apache.org>]

ppkarwasz commented on code in PR #1264:
URL: https://github.com/apache/logging-log4j2/pull/1264#discussion_r1096336077


##########
src/changelog/.2.x.x/1166_simplify_site_generation.xml:
##########
@@ -15,7 +15,10 @@
    See the License for the specific language governing permissions and
    limitations under the License.
 -->
-<entry type="changed">
+<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+       xmlns="http://logging.apache.org/log4j/changelog"
+       xsi:schemaLocation="http://logging.apache.org/log4j/changelog https://logging.apache.org/log4j/changelog-0.1.0.xsd"
+       type="changed">

Review Comment:
   The attributes are in canonical order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org