[GitHub] cloudstack pull request #843: Security group ingress/egress issues with xens...

[jayapalu <gi...@git.apache.org>]

Github user jayapalu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/843#discussion_r100766384
  
    --- Diff: scripts/vm/hypervisor/xenserver/vmops ---
    @@ -356,18 +356,25 @@ def allow_egress_traffic(session):
                     return 'false'
         return 'true'
     
    +def getIpsetType():
    +    try:
    +        util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"])
    +        return 'nethash'
    --- End diff --
    
    For xenserver 6.5 the ipset version is 6.  For xenserver version less than 6.5 (i.e 6.2) the ipset version is 4.x. 
    if ipset version is 6 then it uses nethash otherwise it uses iptreemap
    The getIpsetType method is as below.
    def getIpsetType():
        try:
            util.pread2(['/bin/bash', '-c', "ipset -v | grep 'protocol version: 6'"])
            return 'nethash'
        except:
            return 'iptreemap'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---