You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by strotyl <gi...@git.apache.org> on 2016/06/30 20:23:04 UTC
[GitHub] trafficserver pull request #775: TS-4598 : Coverity Null-Check after deref i...
GitHub user strotyl opened a pull request:
https://github.com/apache/trafficserver/pull/775
TS-4598 : Coverity Null-Check after deref in NetworkUtilisRemote.cc
This is fixing Coverity issue CID 1237320.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/strotyl/trafficserver TS-4598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/775.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #775
----
commit dd9d9c8ef77c9bdd31ff8fb6ce998d2ec46cc73b
Author: Tyler Stroh <ts...@apple.com>
Date: 2016-06-27T21:55:36Z
TS-4598 : Coverity Null-Check after deref in NetworkUtilisRemote.cc
This is fixing Coverity issue CID 1237320.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/775
Yeah, this seems right, TSEventDestroy() checks its argument, and we use it like this in several other places (which is likely why coverity gets confused). Consistency is good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/775
It seems there are merge conflicts here though, Tyler, can you please rebase your tree (which probably means pushing up the main master into your fork first) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/775
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/775
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/295/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/775
s/NetworkUtilisRemote/NetworkUtilsRemote/ ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/775
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/399/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #775: TS-4598 : Coverity Null-Check after deref in Netwo...
Posted by strotyl <gi...@git.apache.org>.
Github user strotyl commented on the issue:
https://github.com/apache/trafficserver/pull/775
Will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #775: TS-4598 : Coverity Null-Check after deref i...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---