You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Dapeng Sun <da...@intel.com> on 2016/03/22 08:38:20 UTC

Review Request 45152: SENTRY-1156: TestDbColumnLevelMetaDataOps should add `use database` for user session created

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45152/
-----------------------------------------------------------

Review request for sentry and Colin Ma.


Bugs: SENTRY-1156
    https://issues.apache.org/jira/browse/SENTRY-1156


Repository: sentry


Description
-------

for the Tests like TestDbColumnLevelMetaDataOps#testShowNewColumn()
    establishSession(USER1_1);
    statement.execute("USE " + TEST_COL_METADATA_OPS_DB);
We should add statement.execute("USE " + TEST_COL_METADATA_OPS_DB); before executing queries...


Diffs
-----

  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java a454202 

Diff: https://reviews.apache.org/r/45152/diff/


Testing
-------


Thanks,

Dapeng Sun


Re: Review Request 45152: SENTRY-1156: TestDbColumnLevelMetaDataOps should add `use database` for user session created

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45152/#review124750
-----------------------------------------------------------


Ship it!




Ship It!

- Colin Ma


On March 22, 2016, 7:38 a.m., Dapeng Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45152/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 7:38 a.m.)
> 
> 
> Review request for sentry and Colin Ma.
> 
> 
> Bugs: SENTRY-1156
>     https://issues.apache.org/jira/browse/SENTRY-1156
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> for the Tests like TestDbColumnLevelMetaDataOps#testShowNewColumn()
>     establishSession(USER1_1);
>     statement.execute("USE " + TEST_COL_METADATA_OPS_DB);
> We should add statement.execute("USE " + TEST_COL_METADATA_OPS_DB); before executing queries...
> 
> 
> Diffs
> -----
> 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java a454202 
> 
> Diff: https://reviews.apache.org/r/45152/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dapeng Sun
> 
>


Re: Review Request 45152: SENTRY-1156: TestDbColumnLevelMetaDataOps should add `use database` for user session created

Posted by Anne Yu <an...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45152/#review126976
-----------------------------------------------------------


Ship it!




Ship It!

- Anne Yu


On March 22, 2016, 7:38 a.m., Dapeng Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45152/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 7:38 a.m.)
> 
> 
> Review request for sentry and Colin Ma.
> 
> 
> Bugs: SENTRY-1156
>     https://issues.apache.org/jira/browse/SENTRY-1156
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> for the Tests like TestDbColumnLevelMetaDataOps#testShowNewColumn()
>     establishSession(USER1_1);
>     statement.execute("USE " + TEST_COL_METADATA_OPS_DB);
> We should add statement.execute("USE " + TEST_COL_METADATA_OPS_DB); before executing queries...
> 
> 
> Diffs
> -----
> 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java a454202 
> 
> Diff: https://reviews.apache.org/r/45152/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dapeng Sun
> 
>