You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/02 12:22:51 UTC
[GitHub] [incubator-iotdb] JulianFeinauer opened a new pull request #1148: Feature/docker for iotdb grafana
JulianFeinauer opened a new pull request #1148:
URL: https://github.com/apache/incubator-iotdb/pull/1148
This PR introduces a Dockerfile as well as some documentation to build a Docker Image of the IOTDB-Grafana Adapter for users convenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1148: Feature/docker for iotdb grafana
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1148:
URL: https://github.com/apache/incubator-iotdb/pull/1148#issuecomment-622958240
well, no apache hader...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1148: Feature/docker for iotdb grafana
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1148:
URL: https://github.com/apache/incubator-iotdb/pull/1148#discussion_r418953963
##########
File path: grafana/Dockerfile
##########
@@ -0,0 +1,12 @@
+FROM openjdk:11-jre-slim
+LABEL maintainer="j.feinauer@pragmaticminds.de"
+RUN mkdir /iotdb
+
+ADD target/iotdb-grafana-*.war /iotdb/iotdb-grafana.war
+ADD src/main/resources/application.properties /iotdb/
+
+EXPOSE 8888
+EXPOSE 4000
Review comment:
4000 port is for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1148: Feature/docker for iotdb grafana
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1148:
URL: https://github.com/apache/incubator-iotdb/pull/1148#discussion_r418955553
##########
File path: grafana/README_DOCKER.md
##########
@@ -0,0 +1,28 @@
+# Docker Container for IoTDB Grafana Adapter
+
+## Build
+
+* `mvn clean package`
+* in the module root execute `docker image build -t apache/iotdb-grafana:{version} .` where version is e.g. 0.9.3.
Review comment:
Hi, now we only have apache/iotdb repo...
If we need apache/iotdb-grafana, we need to apply a new repo from INFRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org