You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "sbp (via GitHub)" <gi...@apache.org> on 2026/04/13 15:12:54 UTC
[I] Hard link files in the incubator directory for podling releases (tooling-trusted-releases)
sbp opened a new issue, #1157:
URL: https://github.com/apache/tooling-trusted-releases/issues/1157
In the announce route we do:
```python
description_download_prefix = f"https://{config.get().APP_HOST}/downloads"
if committee.is_podling:
description_download_prefix += "/incubator"
description_download_prefix += f"/{committee.key}"
```
Which is correct, and similarly when we e.g. show the user a `KEYS` path we make sure that `incubator` is a component of the downloads URL when constructing that. In `atr.storage.writers.announce`, in `CommitteeMember.__hard_link_downloads`, however, we don't seem to do that:
```python
downloads_base_path = paths.get_downloads_dir()
downloads_path = downloads_base_path / committee.key
if download_path_suffix is not None:
downloads_path = downloads_path / download_path_suffix.as_path()
```
We need to fix this and add regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Hard link files in the incubator directory for podling releases (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #1157:
URL: https://github.com/apache/tooling-trusted-releases/issues/1157#issuecomment-4245217516
Resolved by 938784dbebd5c309c45b8892b6941d0bb5684c19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org
Re: [I] Hard link files in the incubator directory for podling releases (tooling-trusted-releases)
Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #1157: Hard link files in the incubator directory for podling releases
URL: https://github.com/apache/tooling-trusted-releases/issues/1157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org