You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/13 12:58:47 UTC
[GitHub] [apisix] kwanhur opened a new pull request #6306: build: rm luarocks tar file behind successful installation
kwanhur opened a new pull request #6306:
URL: https://github.com/apache/apisix/pull/6306
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
remove `luarocks` downloaded tar file
1. successfully install it, no need to reserve it.
2. install script remove the untar files (line#45)[https://github.com/apache/apisix/blob/master/utils/linux-install-luarocks.sh#L45], so remove the tar file simultaneously.
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r805341340
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
Could we remove it just after untar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r805341340
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
Could we remove it just after untar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r807513961
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -25,6 +25,7 @@ fi
LUAROCKS_VER=3.8.0
wget https://github.com/luarocks/luarocks/archive/v"$LUAROCKS_VER".tar.gz
tar -xf v"$LUAROCKS_VER".tar.gz
+rm -f luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
```suggestion
rm -f v"$LUAROCKS_VER".tar.gz
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r806461717
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
ok, remove it behind untar was better, I'll update this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6306:
URL: https://github.com/apache/apisix/pull/6306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r805466059
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
> Could we remove it just after untar?
on this way, if `configure` failed, it need to download archive file `v3.8.0.tar.gz` repeatedly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r806425026
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
Yes. But they change the same thing twice. So why not put together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r805532496
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
OK. So that we can also handle https://github.com/apache/apisix/issues/6307 in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r805558979
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
no, #6307 occurs at `configure` failure, so download twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r806425026
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
Yes. But they change the same thing twice. So why not put together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6306: build: rm luarocks tar file behind successful installation
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6306:
URL: https://github.com/apache/apisix/pull/6306#discussion_r806461717
##########
File path: utils/linux-install-luarocks.sh
##########
@@ -42,7 +42,7 @@ fi
make build > build.log 2>&1 || (cat build.log && exit 1)
sudo make install > build.log 2>&1 || (cat build.log && exit 1)
cd .. || exit
-rm -rf luarocks-"$LUAROCKS_VER"
+rm -rf luarocks-"$LUAROCKS_VER" luarocks-"$LUAROCKS_VER".tar.gz
Review comment:
ok, remove it behind untar was better, I'll update this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org