[GitHub] [lucene] vigyasharma commented on pull request #948: Fix typo in PostingsReaderBase docstring

[GitBox <gi...@apache.org>]

vigyasharma commented on PR #948:
URL: https://github.com/apache/lucene/pull/948#issuecomment-1150395272

   > It looks to me as if the writer may intended `ImpactsEnum` there? Maybe check git blame to see when that edit was made...
   
   Good idea. I checked git history and found [this commit](https://github.com/apache/lucene/commit/c13216934c58870b487a9bd04b2fd4ea24431000#diff-dde065fe5990e588a2a00cb720b3df719655db2cb84d0cb2168519445fedf993), where 
   ```java
   /**
    *  of this class to manage creation of {@link DocsEnum} and
    *  {@link DocsAndPositionsEnum} instances. 
    * /
   
   was replaced by 
   
   /**
    *  of this class to manage creation of {@link org.apache.lucene.index.PostingsEnum} and
    *  {@link org.apache.lucene.index.PostingsEnum} instances. 
    * /
   ```
   
   I guess earlier we had separate `DocsEnum` and `DocsAndPositionsEnum`, but now both can be handled within the `PostingsEnum`? 
   
   The class, however, does provide for creating `ImpactsEnum` (added later [here](https://github.com/apache/lucene/commit/af680af77f3f80c779e038a0ad8a136c9dcb9f5d)), and we can mention that in the doc string. I'll update the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org