You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2019/12/17 23:35:13 UTC
Review Request 71922: ATLAS-3564: New version of AWS S3 model addition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, Object doesn't have version information, both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs
-----
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/1/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219226
-----------------------------------------------------------
addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json
Lines 113 (patched)
<https://reviews.apache.org/r/71922/#comment307384>
aws_s3_v2_object already has DataSet as supertype, hence no need to have it added again in aws_s3_v2_directory.
- Madhan Neethiraj
On Jan. 11, 2020, 1:50 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2020, 1:50 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219232
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 13, 2020, 5:40 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2020, 5:40 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219242
-----------------------------------------------------------
- Madhan Neethiraj
On Jan. 13, 2020, 8:06 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2020, 8:06 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219245
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Jan. 13, 2020, 8:06 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2020, 8:06 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 13, 2020, 8:06 p.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/7/
Changes: https://reviews.apache.org/r/71922/diff/6-7/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 13, 2020, 5:40 a.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/6/
Changes: https://reviews.apache.org/r/71922/diff/5-6/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 11, 2020, 1:50 a.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/5/
Changes: https://reviews.apache.org/r/71922/diff/4-5/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 10, 2020, 7:13 p.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/4/
Changes: https://reviews.apache.org/r/71922/diff/3-4/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219185
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 8, 2020, 3:12 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2020, 3:12 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 15 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line15>
> >
> > Rename: aws_s3_v2_contained (since containee does not exist in english language)
What will be relationship name - aws_s3_v2_container_contained?
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 20 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line20>
> >
> > Should contain ownerId.
We have OwnerName which will be usefull for Atlas. Do you think OwnerId like f9fca4893bbb1d52d88edbcf22a42cc5b81c29496c8b881fc160faab93c73945 which is specific to aws it worth adding to atals model?
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line21>
> >
> > Add bucketName, since all objects have it.
The qualified name in each object will have bucketName. Should we add another item for it. That will be redundant.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 23 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line23>
> >
> > Considering adding: bucketName.
same as above.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 58 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line58>
> >
> > Should be moved to base class. Since every s3 object has this.
This is the object base type and directory is derived from this
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 111 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line111>
> >
> > Consider adding: Region
The qualified name in each object will have Region as well. Should we add another item for it. That will be redundant.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 121 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line121>
> >
> > What is the purpose of this?
This is being added for backward compatibility i.e. if we can eventually move from older version to new one completely.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 129 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line129>
> >
> > What is the purpose of this?
same as above
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line137>
> >
> > Rename: currentStorageLocation to location.
rename to storageLocation as only location may be confusing with path or key. Please suggest.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 190 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line190>
> >
> > What is the purpose of this?
This is being added for backward compatibility i.e. if we can eventually move from older version to new one completely.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 214 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line214>
> >
> > I think this attribute is at object level.
I have removed isEncrypted.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 222 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line222>
> >
> > This is at object level.
Bucket is not derived from object and thats the reason we have this at both the places. Only this and tag is common property among object and bucket. Do you think extracting these two to another basetype will make sense?
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 238 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line238>
> >
> > This should be part of base class.
same as above.
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219215
-----------------------------------------------------------
On Jan. 8, 2020, 11:12 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2020, 11:12 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 15 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line15>
> >
> > Rename: aws_s3_v2_contained (since containee does not exist in english language)
>
> Sidharth Mishra wrote:
> What will be relationship name - aws_s3_v2_container_contained?
Yes.
> On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote:
> > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
> > Lines 20 (patched)
> > <https://reviews.apache.org/r/71922/diff/3/?file=2199453#file2199453line20>
> >
> > Should contain ownerId.
>
> Sidharth Mishra wrote:
> We have OwnerName which will be usefull for Atlas. Do you think OwnerId like f9fca4893bbb1d52d88edbcf22a42cc5b81c29496c8b881fc160faab93c73945 which is specific to aws it worth adding to atals model?
Yes.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219215
-----------------------------------------------------------
On Jan. 13, 2020, 5:40 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2020, 5:40 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219215
-----------------------------------------------------------
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 15 (patched)
<https://reviews.apache.org/r/71922/#comment307336>
Rename: aws_s3_v2_contained (since containee does not exist in english language)
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 20 (patched)
<https://reviews.apache.org/r/71922/#comment307339>
Should contain ownerId.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 21 (patched)
<https://reviews.apache.org/r/71922/#comment307346>
Add bucketName, since all objects have it.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 23 (patched)
<https://reviews.apache.org/r/71922/#comment307337>
Considering adding: bucketName.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 24 (patched)
<https://reviews.apache.org/r/71922/#comment307338>
Consider adding: encryption
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 58 (patched)
<https://reviews.apache.org/r/71922/#comment307345>
Should be moved to base class. Since every s3 object has this.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 102 (patched)
<https://reviews.apache.org/r/71922/#comment307340>
Rename: aws_s3_v2_directory
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 111 (patched)
<https://reviews.apache.org/r/71922/#comment307341>
Consider adding: Region
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 121 (patched)
<https://reviews.apache.org/r/71922/#comment307342>
What is the purpose of this?
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 129 (patched)
<https://reviews.apache.org/r/71922/#comment307343>
What is the purpose of this?
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 137 (patched)
<https://reviews.apache.org/r/71922/#comment307344>
Rename: currentStorageLocation to location.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 168 (patched)
<https://reviews.apache.org/r/71922/#comment307347>
Need not be indexable.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 190 (patched)
<https://reviews.apache.org/r/71922/#comment307348>
What is the purpose of this?
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 214 (patched)
<https://reviews.apache.org/r/71922/#comment307349>
I think this attribute is at object level.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 222 (patched)
<https://reviews.apache.org/r/71922/#comment307350>
This is at object level.
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 238 (patched)
<https://reviews.apache.org/r/71922/#comment307351>
This should be part of base class.
- Ashutosh Mestry
On Jan. 8, 2020, 11:12 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2020, 11:12 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 8, 2020, 11:12 p.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/3/
Changes: https://reviews.apache.org/r/71922/diff/2-3/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219181
-----------------------------------------------------------
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 7 (patched)
<https://reviews.apache.org/r/71922/#comment307297>
aws_s3_v2_container => aws_s3_container_v2
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 15 (patched)
<https://reviews.apache.org/r/71922/#comment307298>
aws_s3_v2_containee => aws_s3_containee_v2
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 23 (patched)
<https://reviews.apache.org/r/71922/#comment307299>
aws_s3_v2_object => aws_s3_object_v2
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 102 (patched)
<https://reviews.apache.org/r/71922/#comment307300>
aws_s3_v2_pseudo_dir => aws_s3_pseudo_dir_v2
update line 106 and 107 as well
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 147 (patched)
<https://reviews.apache.org/r/71922/#comment307301>
aws_s3_v2_bucket => aws_s3_bucket_v2
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 258 (patched)
<https://reviews.apache.org/r/71922/#comment307302>
aws_s3_v2_container_containees => aws_s3_container_containees_v2
update 264 and 269
- Sarath Subramanian
On Jan. 8, 2020, 10:54 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2020, 10:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/#review219183
-----------------------------------------------------------
Fix it, then Ship it!
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json
Lines 266 (patched)
<https://reviews.apache.org/r/71922/#comment307303>
remove ending comma (','), same for line 272
- Sarath Subramanian
On Jan. 8, 2020, 10:54 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71922/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2020, 10:54 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3564
> https://issues.apache.org/jira/browse/ATLAS-3564
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
>
>
> Diffs
> -----
>
> addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71922/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 8, 2020, 6:54 p.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs (updated)
-----
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/2/
Changes: https://reviews.apache.org/r/71922/diff/1-2/
Testing
-------
Thanks,
Sidharth Mishra
Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model
addition
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71922/
-----------------------------------------------------------
(Updated Jan. 8, 2020, 6:54 p.m.)
Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and Sarath Subramanian.
Bugs: ATLAS-3564
https://issues.apache.org/jira/browse/ATLAS-3564
Repository: atlas
Description (updated)
-------
This is the new version) of aws s3 model at atlas to allow the hierarchical structure and attributes same as AWS S3 Console. The existing aws s3 models has limitations like pseudo directory not containing another pseudo directory, pseudo directory doesn't have attributes of aws object (as some case it gets populated), both object and bucket doesn't containing all the attributes of AWS S3 etc.
Diffs
-----
addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION
Diff: https://reviews.apache.org/r/71922/diff/1/
Testing
-------
Thanks,
Sidharth Mishra