You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sspans <gi...@git.apache.org> on 2015/07/29 15:46:33 UTC

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

GitHub user sspans opened a pull request:

    https://github.com/apache/cloudstack/pull/636

    Update NiciraNvpGuestNetworkGuru.java

    Add support for VXLAN as isolation method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sspans/cloudstack vxlan-patch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/636.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #636
    
----
commit d03505acc2f7e6a6569201dca633dc1097df5cf5
Author: Sten Spans <st...@blinkenlights.nl>
Date:   2015-07-29T13:45:41Z

    Update NiciraNvpGuestNetworkGuru.java
    
    Add support for VXLAN as isolation method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by sspans <gi...@git.apache.org>.
Github user sspans commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126250153
  
    Testing and a unit-test will still be added.
    
    We need this feature because we're planning to roll out new zones with VXLAN,
    which if the changes remain small would ideally also be backported to 4.4.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by kishankavala <gi...@git.apache.org>.
Github user kishankavala commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126288404
  
    @sspans 
    Since Test case is updated to cover VXLAN also, LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by sspans <gi...@git.apache.org>.
Github user sspans commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126247958
  
    Daan: any supported release of vmware nsx will support VXLAN.
    People running older releases probably already have an STT setup running, and should not encounter problems following these changes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126250367
  
    @sspans yes but they might be tempted to do some vxlanning after upgrading ACS not upgrading NSX . what would happen?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by sspans <gi...@git.apache.org>.
Github user sspans commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126257887
  
    The plugin would fail, similar to how it fails now when you ask ik to do vxlan when it only supports STT.
    The encapsulation type is something that you first configure in NSX and then in cloudstack.
    So the scenario you're trying to propose is really very unrealistic.
    
    NB: NSX releases supporting only STT don't seem to be available for download anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-125961987
  
    @sspans any testing done?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126258728
  
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/636


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/636#issuecomment-126047538
  
    does every version of nvp support vxlan?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---