[GitHub] [arrow] westonpace commented on pull request #34102: GH-33976: [Python] Initial bindings for acero Declaration and ExecNodeOptions classes

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on PR #34102:
URL: https://github.com/apache/arrow/pull/34102#issuecomment-1434921113

   > While updating here based on your feedback, would it be useful to directly also update it in the C++ source?
   
   Yes, if you don't mind.  The lengthy join explanation was mostly just because I was recently doing some Substrait work and so I had the detailed explanation still loaded up in short term memory.  I think it would be quite helpful to add to the C++ documentation as well.
   
   > (but maybe you prefer to keep the doc comments in options.h/exec_plan.h shorter?)
   
   I don't mind [long](https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/async_util.h#L41-L65) [doc](https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/async_generator.h#L40-L69) [comments](https://github.com/apache/arrow/blob/main/cpp/src/arrow/dataset/dataset_writer.h#L60-L83) when the situation warrants. :laughing: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org