You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Felix Berger (JIRA)" <ji...@apache.org> on 2010/10/12 20:27:33 UTC

[jira] Created: (HTTPCLIENT-1011) CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()

CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()
----------------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-1011
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1011
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: Cache
    Affects Versions: 4.1 Alpha2
            Reporter: Felix Berger


The IOException caused by the HttpCache is not caught and thus the whole http request fails. I would expect the response to be retrieved from the backend when the cache fails for some reason.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Resolved: (HTTPCLIENT-1011) CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1011.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.1 Alpha3

Patch checked in. Many thanks, Jon.

Oleg

> CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1011
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1011
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Felix Berger
>             Fix For: 4.1 Alpha3
>
>         Attachments: cache-ioexception.patch
>
>
> The IOException caused by the HttpCache is not caught and thus the whole http request fails. I would expect the response to be retrieved from the backend when the cache fails for some reason.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Commented: (HTTPCLIENT-1011) CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920291#action_12920291 ] 

Jonathan Moore commented on HTTPCLIENT-1011:
--------------------------------------------

I would actually call this a bug. :)

> CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1011
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1011
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Felix Berger
>
> The IOException caused by the HttpCache is not caught and thus the whole http request fails. I would expect the response to be retrieved from the backend when the cache fails for some reason.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCLIENT-1011) CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()

Posted by "Jonathan Moore (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Moore updated HTTPCLIENT-1011:
---------------------------------------

    Attachment: cache-ioexception.patch

The attached patch fixes this issue; now cache IOExceptions are caught, logged at WARN, and then ignored (hooray, HTTP protocol robustness to failure).

This patch is contributed to the ASF with the permission of my employer.


> CachingHttpClient.execute() does not catch the IOException thrown by HttpCache.getCacheEntry()
> ----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1011
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1011
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Felix Berger
>         Attachments: cache-ioexception.patch
>
>
> The IOException caused by the HttpCache is not caught and thus the whole http request fails. I would expect the response to be retrieved from the backend when the cache fails for some reason.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org