You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/01/18 07:20:52 UTC

[GitHub] [buildstream] juergbi edited a comment on pull request #1568: fuse: Pass through the underlying filesystem's inode numbers

juergbi edited a comment on pull request #1568:
URL: https://github.com/apache/buildstream/pull/1568#issuecomment-1015132613


   A potential issue I see is that `ensure_copy()` can cause the inode number of an existing file to change when it shouldn't. I don't know whether there are any applications where this would cause an issue. It's likely that filling in the inode number is more important than the potential inconsistency.
   
   OSTree's `rofiles-fuse` also passes through the inode number, an indication that this is not a significant issue.
   https://github.com/ostreedev/ostree/blob/main/src/rofiles-fuse/main.c#L137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org