You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/21 08:21:55 UTC

[GitHub] [flink] yuchuanchen opened a new pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

yuchuanchen opened a new pull request #13718:
URL: https://github.com/apache/flink/pull/13718


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Pick another disk(tmpDir) for Spilling Channel, rather than throw an IOException, which causes flink job restart over and over again.
   
   
   ## Brief change log
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *SpanningWrapperTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 61d088bc24fa8610f1c03cef9b94197107f91b04 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002) 
   * 5c96af1117f6f6ac03ba38c20af505fe7a6bae4f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8338",
       "triggerID" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 61d088bc24fa8610f1c03cef9b94197107f91b04 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002) 
   * 5c96af1117f6f6ac03ba38c20af505fe7a6bae4f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8338) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-717663344


   @pnowojski Is squashed the commits and opened a new pull request.
   https://github.com/apache/flink/pull/13810


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-717750630


   Thanks @yuchuanchen .
   
   Note for the future, you didn't have to open new PR :) It would be fine to update this one.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 61d088bc24fa8610f1c03cef9b94197107f91b04 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 926247a70813fd03200795f8c1c585ff95386ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r513141863



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);
+			String directory = tempDirs[dirIndex];
 			File file = new File(directory, randomString(rnd) + ".inputchannel");
-			if (file.createNewFile()) {
-				spillFile = new RefCountedFile(file);
-				return new RandomAccessFile(file, "rw").getChannel();
+			try {
+				if (file.createNewFile()) {
+					spillFile = new RefCountedFile(file);
+					return new RandomAccessFile(file, "rw").getChannel();
+				}
+			} catch (IOException e) {
+				// if there is no tempDir left to try
+				if (tempDirs.length <= 1) {
+					throw e;
+				}
+				LOG.warn("Caught an IOException when creating spill file: " + directory + ". Attempt " + attempt, e);
+				tempDirs = (String[]) ArrayUtils.remove(tempDirs, dirIndex);

Review comment:
       Agree with that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713399259


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 926247a70813fd03200795f8c1c585ff95386ee2 (Wed Oct 21 08:24:06 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18811).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r512376180



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);
+			String directory = tempDirs[dirIndex];
 			File file = new File(directory, randomString(rnd) + ".inputchannel");
-			if (file.createNewFile()) {
-				spillFile = new RefCountedFile(file);
-				return new RandomAccessFile(file, "rw").getChannel();
+			try {
+				if (file.createNewFile()) {
+					spillFile = new RefCountedFile(file);
+					return new RandomAccessFile(file, "rw").getChannel();
+				}
+			} catch (IOException e) {
+				// if there is no tempDir left to try
+				if (tempDirs.length <= 1) {
+					throw e;
+				}
+				LOG.warn("Caught an IOException when creating spill file: " + directory + ". Attempt " + attempt, e);
+				tempDirs = (String[]) ArrayUtils.remove(tempDirs, dirIndex);

Review comment:
       Or we just remove the ”LOG.warn“ here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 926247a70813fd03200795f8c1c585ff95386ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993) 
   * 61d088bc24fa8610f1c03cef9b94197107f91b04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-717758921


   Thanks @pnowojski


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r512370998



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);

Review comment:
       yeah,that's a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r511867252



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);

Review comment:
       maybe instead of random picking a directory per every attempt, just randomly pick a starting directory index and then per each attempt increase it by one. +/- something like that:
   ```
   int initialDirIndex = rnd.nextInt(...);
   for (int attempt = 0; attempt < maxAttempts; attempt++) {
     int dirIndex = (initialDirIndex + attempt) % tempDirs.length;
     ...
   }
   ```
   ?

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);
+			String directory = tempDirs[dirIndex];
 			File file = new File(directory, randomString(rnd) + ".inputchannel");
-			if (file.createNewFile()) {
-				spillFile = new RefCountedFile(file);
-				return new RandomAccessFile(file, "rw").getChannel();
+			try {
+				if (file.createNewFile()) {
+					spillFile = new RefCountedFile(file);
+					return new RandomAccessFile(file, "rw").getChannel();
+				}
+			} catch (IOException e) {
+				// if there is no tempDir left to try
+				if (tempDirs.length <= 1) {
+					throw e;
+				}
+				LOG.warn("Caught an IOException when creating spill file: " + directory + ". Attempt " + attempt, e);
+				tempDirs = (String[]) ArrayUtils.remove(tempDirs, dirIndex);

Review comment:
       If we settle on such trivial approach to the problem (without temporary blacklisting), I wouldn't remove the failed dir from the `tempDir`, but just keep it and re-try next time?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-717663344


   Hi @pnowojski, I squashed the commits and opened a new pull request.
   https://github.com/apache/flink/pull/13810


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen closed pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen closed pull request #13718:
URL: https://github.com/apache/flink/pull/13718


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8002",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8338",
       "triggerID" : "5c96af1117f6f6ac03ba38c20af505fe7a6bae4f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5c96af1117f6f6ac03ba38c20af505fe7a6bae4f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8338) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] pnowojski commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r512677181



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);
+			String directory = tempDirs[dirIndex];
 			File file = new File(directory, randomString(rnd) + ".inputchannel");
-			if (file.createNewFile()) {
-				spillFile = new RefCountedFile(file);
-				return new RandomAccessFile(file, "rw").getChannel();
+			try {
+				if (file.createNewFile()) {
+					spillFile = new RefCountedFile(file);
+					return new RandomAccessFile(file, "rw").getChannel();
+				}
+			} catch (IOException e) {
+				// if there is no tempDir left to try
+				if (tempDirs.length <= 1) {
+					throw e;
+				}
+				LOG.warn("Caught an IOException when creating spill file: " + directory + ". Attempt " + attempt, e);
+				tempDirs = (String[]) ArrayUtils.remove(tempDirs, dirIndex);

Review comment:
       Ok, good point. Let's keep it as it is. At worst if there are some intermittent errors and we deplete the available temp dirs, job will restart and re attempt to write to the same directories (and the intermittent error might be gone by then). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 926247a70813fd03200795f8c1c585ff95386ee2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13718:
URL: https://github.com/apache/flink/pull/13718#issuecomment-713418812


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993",
       "triggerID" : "926247a70813fd03200795f8c1c585ff95386ee2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "61d088bc24fa8610f1c03cef9b94197107f91b04",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 926247a70813fd03200795f8c1c585ff95386ee2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7993) 
   * 61d088bc24fa8610f1c03cef9b94197107f91b04 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] yuchuanchen commented on a change in pull request #13718: [FLINK-18811] Pick another tmpDir if an IOException occurs when creating spill file

Posted by GitBox <gi...@apache.org>.
yuchuanchen commented on a change in pull request #13718:
URL: https://github.com/apache/flink/pull/13718#discussion_r512373050



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningWrapper.java
##########
@@ -286,11 +292,21 @@ private FileChannel createSpillingChannel() throws IOException {
 		// try to find a unique file name for the spilling channel
 		int maxAttempts = 10;
 		for (int attempt = 0; attempt < maxAttempts; attempt++) {
-			String directory = tempDirs[rnd.nextInt(tempDirs.length)];
+			int dirIndex = rnd.nextInt(tempDirs.length);
+			String directory = tempDirs[dirIndex];
 			File file = new File(directory, randomString(rnd) + ".inputchannel");
-			if (file.createNewFile()) {
-				spillFile = new RefCountedFile(file);
-				return new RandomAccessFile(file, "rw").getChannel();
+			try {
+				if (file.createNewFile()) {
+					spillFile = new RefCountedFile(file);
+					return new RandomAccessFile(file, "rw").getChannel();
+				}
+			} catch (IOException e) {
+				// if there is no tempDir left to try
+				if (tempDirs.length <= 1) {
+					throw e;
+				}
+				LOG.warn("Caught an IOException when creating spill file: " + directory + ". Attempt " + attempt, e);
+				tempDirs = (String[]) ArrayUtils.remove(tempDirs, dirIndex);

Review comment:
       I did the same as you suggest, and it probably leads to too many "WARNING" logs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org