You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2015/02/27 13:55:09 UTC

[Bug 57641] New: mod_substitute: Invalid merge order

https://bz.apache.org/bugzilla/show_bug.cgi?id=57641

            Bug ID: 57641
           Summary: mod_substitute: Invalid merge order
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P2
         Component: mod_substitute
          Assignee: bugs@httpd.apache.org
          Reporter: marc.stern@approach.be

httpd - and all modules - use the same order to merge the options and execute
the related actions:
 - global scope
 - vhost scope
 - location scope (in sequential order)

mod_substitute execute the actions the other way around:
 - location scope (in sequential order)
 - vhost scope
 - global scope

This is incompatible with the logic used by the whole project.

Details of the code:
in merge_substitute_dcfg(), we have
 a->patterns = apr_array_append(p, over->patterns, base->patterns);
This should be
 a->patterns = apr_array_append(p, base->patterns, over->patterns);

The problem lies in all versions

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 57641] mod_substitute: Invalid merge order

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57641

--- Comment #3 from Yann Ylavic <yl...@gmail.com> ---
Backport also proposed to 2.2.x in r1685978.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 57641] mod_substitute: Invalid merge order

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57641

--- Comment #2 from Marc Stern <ma...@approach.be> ---
Can we backport it to 2.2 also?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 57641] mod_substitute: Invalid merge order

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57641

Marc Stern <ma...@approach.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 57641] mod_substitute: Invalid merge order

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57641

Yann Ylavic <yl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk

--- Comment #1 from Yann Ylavic <yl...@gmail.com> ---
Applied to trunk in r1684900.
Backport to 2.4.x proposed r1684900.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org