You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 14:40:09 UTC

[GitHub] [flink] matriv opened a new pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

matriv opened a new pull request #19270:
URL: https://github.com/apache/flink/pull/19270


   ## What is the purpose of the change
   
   Previously, `LEAST` and `GREATEST` functions would return primitive
   types in the generated code implementing their logic, producing issues
   for operators applied on top of them, and most importantly comparison
   operators, i.e.:
   ```
   f0 INT, f1 INT
   SELECT GREATEST(f0, f1) = GREATEST(f0, f1)
   ```
   would return `FALSE`, since the generated code would return `Integer`
   instead of `int`, as the result of `GREATEST`, and the `=` operator
   on `Integer` objects would return false, even if the actual integer
   value of them was the same.
   
   
   ## Brief change log
   
     - Change code generation for `LEAST`/`GREATEST` to return primitive types instead of boxed, (null is already handled correctly with the use of `nullTerm`s.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added more tests in `GreatestLeastFunctionsITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive):**no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] matriv commented on pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #19270:
URL: https://github.com/apache/flink/pull/19270#issuecomment-1081959266


   Needs to be backported to `1.15` as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged pull request #19270:
URL: https://github.com/apache/flink/pull/19270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19270:
URL: https://github.com/apache/flink/pull/19270#issuecomment-1081967660


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33910",
       "triggerID" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33910) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19270:
URL: https://github.com/apache/flink/pull/19270#issuecomment-1081967660


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19270: [FLINK-25227][table-planner] Fix LEAST/GREATEST to return primitives

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19270:
URL: https://github.com/apache/flink/pull/19270#issuecomment-1081967660


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33910",
       "triggerID" : "fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb38af6df00d956cc7912b7b5f7ae8efd8c58a0d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33910) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org