You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/04/20 10:58:47 UTC
[GitHub] [brooklyn-server] duncangrant opened a new pull request #1091: Update library versions due to CVEs
duncangrant opened a new pull request #1091:
URL: https://github.com/apache/brooklyn-server/pull/1091
Fixes the following CVEs
https://nvd.nist.gov/vuln/detail/CVE-2017-5929
https://nvd.nist.gov/vuln/detail/CVE-2019-10086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] iuliana commented on a change in pull request #1091: Update library versions due to CVEs
Posted by GitBox <gi...@apache.org>.
iuliana commented on a change in pull request #1091:
URL: https://github.com/apache/brooklyn-server/pull/1091#discussion_r411287571
##########
File path: test-support/src/main/java/org/apache/brooklyn/test/LogWatcher.java
##########
@@ -182,7 +182,7 @@ public void doEncode(ILoggingEvent event) throws IOException {
}
LOG.trace("level="+event.getLevel()+"; event="+event+"; msg="+event.getFormattedMessage());
Review comment:
Any reason we are not using the recommended syntax like `LOG.trace("level= {} ; event={} ; msg={}", event.getLevel(), event,event.getFormattedMessage() );` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-server] iuliana commented on issue #1091: Update library versions due to CVEs
Posted by GitBox <gi...@apache.org>.
iuliana commented on issue #1091:
URL: https://github.com/apache/brooklyn-server/pull/1091#issuecomment-616564154
Approved. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org