You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Doug Judd (JIRA)" <ji...@apache.org> on 2010/07/10 15:09:50 UTC

[jira] Created: (THRIFT-817) Syntax Error in concurrency/Mutex.h

Syntax Error in concurrency/Mutex.h
-----------------------------------

                 Key: THRIFT-817
                 URL: https://issues.apache.org/jira/browse/THRIFT-817
             Project: Thrift
          Issue Type: Bug
    Affects Versions: 0.3
         Environment: all
            Reporter: Doug Judd


I installed Thrift 0.3.0.  When I compile my app, I get the following error:

/usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
enumerator list

Looking into this file, there is an extraneous trailing comma:

enum RWGuardType {
  RW_READ = 0,
  RW_WRITE = 1,
};


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-817) Syntax Error in concurrency/Mutex.h

Posted by "noomerikal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

noomerikal updated THRIFT-817:
------------------------------

    Attachment: THRIFT-817.patch

> Syntax Error in concurrency/Mutex.h
> -----------------------------------
>
>                 Key: THRIFT-817
>                 URL: https://issues.apache.org/jira/browse/THRIFT-817
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.3
>         Environment: all
>            Reporter: Doug Judd
>         Attachments: THRIFT-817.patch
>
>
> I installed Thrift 0.3.0.  When I compile my app, I get the following error:
> /usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
> enumerator list
> Looking into this file, there is an extraneous trailing comma:
> enum RWGuardType {
>   RW_READ = 0,
>   RW_WRITE = 1,
> };

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (THRIFT-817) Syntax Error in concurrency/Mutex.h

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier reassigned THRIFT-817:
----------------------------------

    Assignee: Roger Meier

> Syntax Error in concurrency/Mutex.h
> -----------------------------------
>
>                 Key: THRIFT-817
>                 URL: https://issues.apache.org/jira/browse/THRIFT-817
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.3
>         Environment: all
>            Reporter: Doug Judd
>            Assignee: Roger Meier
>         Attachments: THRIFT-817.patch
>
>
> I installed Thrift 0.3.0.  When I compile my app, I get the following error:
> /usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
> enumerator list
> Looking into this file, there is an extraneous trailing comma:
> enum RWGuardType {
>   RW_READ = 0,
>   RW_WRITE = 1,
> };

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-817) Syntax Error in concurrency/Mutex.h

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921880#action_12921880 ] 

Roger Meier commented on THRIFT-817:
------------------------------------

fixed with a commit for THRIFT-916

> Syntax Error in concurrency/Mutex.h
> -----------------------------------
>
>                 Key: THRIFT-817
>                 URL: https://issues.apache.org/jira/browse/THRIFT-817
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.3
>         Environment: all
>            Reporter: Doug Judd
>            Assignee: Roger Meier
>         Attachments: THRIFT-817.patch
>
>
> I installed Thrift 0.3.0.  When I compile my app, I get the following error:
> /usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
> enumerator list
> Looking into this file, there is an extraneous trailing comma:
> enum RWGuardType {
>   RW_READ = 0,
>   RW_WRITE = 1,
> };

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-817) Syntax Error in concurrency/Mutex.h

Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Lavoie closed THRIFT-817.
-----------------------------------

    Resolution: Fixed

Code in head currently looks like this:

{noformat}
132 // Can be used as second argument to RWGuard to make code more readable
133 // as to whether we're doing acquireRead() or acquireWrite().
134 enum RWGuardType {
135   RW_READ = 0,
136   RW_WRITE = 1
137 };
{noformat}

(numbers are line numbers)

> Syntax Error in concurrency/Mutex.h
> -----------------------------------
>
>                 Key: THRIFT-817
>                 URL: https://issues.apache.org/jira/browse/THRIFT-817
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.3
>         Environment: all
>            Reporter: Doug Judd
>         Attachments: THRIFT-817.patch
>
>
> I installed Thrift 0.3.0.  When I compile my app, I get the following error:
> /usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
> enumerator list
> Looking into this file, there is an extraneous trailing comma:
> enum RWGuardType {
>   RW_READ = 0,
>   RW_WRITE = 1,
> };

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.