You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/11 04:08:41 UTC
[GitHub] [pulsar] AnonHxy opened a new pull request #14229: [Producer] log producer batchSize and msgSize stats
AnonHxy opened a new pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229
### Motivation
log the producer batch size percentiles
### Modifications
* Add `batchSizeDs` and `msgSizeDs` in `org.apache.pulsar.client.impl.ProducerStatsRecorderImpl`
* Modify the `org.apache.pulsar.client.impl.ProducerStatsRecorderImpl#updateStats` to log the batch size and msg size percentiles
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1035908575
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1035907971
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1036016778
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy removed a comment on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy removed a comment on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1036012387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1036012387
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy removed a comment on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy removed a comment on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1035908575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] AnonHxy commented on pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#issuecomment-1035908700
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #14229: [Producer] Log producer batchSize and msgSize percentiles
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #14229:
URL: https://github.com/apache/pulsar/pull/14229#discussion_r805113922
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java
##########
@@ -196,6 +223,20 @@ public void incrementNumAcksReceived(long latencyNs) {
}
}
+ @Override
+ public void incrementBatchSize(int batchSize) {
Review comment:
`incrementBatchSize` and `incrementMsgSize` can be done in `updateNumMsgsSent`, no need for new api.
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerStatsRecorderImpl.java
##########
@@ -196,6 +223,20 @@ public void incrementNumAcksReceived(long latencyNs) {
}
}
+ @Override
+ public void incrementBatchSize(int batchSize) {
Review comment:
And missed collect from send operation in `org.apache.pulsar.client.impl.ProducerImpl#recoverProcessOpSendMsgFrom`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org