You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/07/05 23:06:43 UTC
Re: Review Request 60511: Added MockMetadataManager and test
concurrent prune and pull.
> On June 28, 2017, 10:37 p.m., Mesos Reviewbot Windows wrote:
> > Bad patch!
> >
> > Reviews applied: [60511, 56722, 60471, 56721, 59705, 55727, 59687, 55335, 55334]
> >
> > Failed command: python support/apply-reviews.py -n -r 55334
> >
> > Error:
> > Traceback (most recent call last):
> > File "support/apply-reviews.py", line 417, in <module>
> > main()
> > File "support/apply-reviews.py", line 412, in main
> > reviewboard(options)
> > File "support/apply-reviews.py", line 402, in reviewboard
> > apply_review(options)
> > File "support/apply-reviews.py", line 158, in apply_review
> > fetch_patch(options)
> > File "support/apply-reviews.py", line 194, in fetch_patch
> > patch.write(patch.read())
> > IOError: File not open for reading
> >
> > Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/124/console
My bad, though I'd set up the bot to pull master each time it built... I had the remote named incorrectly. This should be resolved now.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60511/#review179197
-----------------------------------------------------------
On June 28, 2017, 6:48 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60511/
> -----------------------------------------------------------
>
> (Updated June 28, 2017, 6:48 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jason Lai.
>
>
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MockMetadataManager and test concurrent prune and pull.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb
> src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab
> src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 8058dcb31b9de59fa8d3638b5511113632235542
> src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4
>
>
> Diff: https://reviews.apache.org/r/60511/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>