[GitHub] villebro opened a new issue #5390: SQL Lab query limit too large to handle default settings

[GitBox <gi...@apache.org>]

villebro opened a new issue #5390: SQL Lab query limit too large to handle default settings
URL: https://github.com/apache/incubator-superset/issues/5390
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if any
   - [x] I have reproduced the issue with at least the latest released version of superset
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar
   
   
   ### Superset version
   master
   
   ### Expected results
   When submitting a query via SQL Lab, the query should only display a sensible amount of rows, e.g. the default value of `DISPLAY_SQL_MAX_ROW` (set to 1,000 in `config.py`).
   
   ### Actual results
   The query is limited to `SQL_MAX_ROW` (set to 1,000,000 in `config.py`), which causes unnecessary strain on the datasource and crashes the browser on large tables.
   
   ### Steps to reproduce
   1. Open SQL Lab
   2. Write query against big table
   3. Wait for browser to crash.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org