[GitHub] [accumulo] EdColeman commented on a diff in pull request #3384: fix 3372 - use waitFor to handle async conditions

["EdColeman (via GitHub)" <gi...@apache.org>]

EdColeman commented on code in PR #3384:
URL: https://github.com/apache/accumulo/pull/3384#discussion_r1187512903


##########
test/src/main/java/org/apache/accumulo/test/functional/MemoryStarvedScanIT.java:
##########
@@ -307,13 +308,16 @@ public void testBatchScanReturnsEarlyDueToLowMemory() throws Exception {
         consumeServerMemory(scanner);
 
         // Wait for longer than the memory check interval
-        Thread.sleep(6000);
+        Thread.sleep(3000);

Review Comment:
   The metrics collection is inherently asynchronous - this was to insert some delay and then use the polling in Wait so that the back off could start small and then start backing off, hopefully reducing the over-all time required for the test by minimizing the total time spent waiting for the metrics to update.
   
   This test in particular seems to have a race condition with the low memory detector that was recently added - so it was the only one addressed here.  The others were left alone for now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org