[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28999: [MINOR][SQL] Re-use GetTimestamp in ParseToDate

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #28999:
URL: https://github.com/apache/spark/pull/28999#discussion_r450519599



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr
   extends RuntimeReplaceable {
 
   def this(left: Expression, format: Expression) {
-      this(left, Option(format),
-        Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))

Review comment:
       Hi, @MaxGekk . If you don't mind, please make a JIRA issue for this. That will give us a traceability for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org