You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2025/10/24 08:19:14 UTC

Re: [PR] [core] format table: jindo io use upload part to support two-phase commit [paimon]

jerry-024 commented on code in PR #6470:
URL: https://github.com/apache/paimon/pull/6470#discussion_r2459280654


##########
paimon-common/src/main/java/org/apache/paimon/fs/MultiPartUploadTwoPhaseOutputStream.java:
##########
@@ -89,10 +89,34 @@ public void write(byte[] b, int off, int len) throws IOException {
         if (closed) {
             throw new IOException("Stream is closed");
         }
-        buffer.write(b, off, len);
-        position += len;
-        if (buffer.size() >= partSizeThreshold()) {
-            uploadPart();
+        int remaining = len;

Review Comment:
   If write data is larger than the threshold, we need to split it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org