You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:42:47 UTC

[GitHub] [spark] huaxingao commented on a diff in pull request #37554: [SPARK-40124][SQL][TEST] Update TPCDS v1.4 q32 for Plan Stability tests

huaxingao commented on code in PR #37554:
URL: https://github.com/apache/spark/pull/37554#discussion_r948127579


##########
sql/core/src/test/resources/tpcds/q32.sql:
##########
@@ -1,4 +1,4 @@
-SELECT 1 AS `excess discount amount `
+SELECT sum(cs_ext_discount_amt) AS `excess discount amount `

Review Comment:
   The change looks good, but do we need the empty space after `amount`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org