You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/18 09:35:06 UTC
[GitHub] [iotdb] ericpai opened a new pull request #5090: [To rel/0.12][IOTDB-2567] Fix thread and ByteBuffer leak after service stopped
ericpai opened a new pull request #5090:
URL: https://github.com/apache/iotdb/pull/5090
See JIRA: https://issues.apache.org/jira/browse/IOTDB-2567.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a change in pull request #5090: [To rel/0.12][IOTDB-2567] Fix thread and ByteBuffer leak after service stopped
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on a change in pull request #5090:
URL: https://github.com/apache/iotdb/pull/5090#discussion_r809958089
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/virtualSg/VirtualStorageGroupManager.java
##########
@@ -432,4 +434,12 @@ public void releaseWalDirectByteBufferPool() {
public void reset() {
Arrays.fill(virtualStorageGroupProcessor, null);
}
+
+ public void stopSchedulerPool() {
+ for (StorageGroupProcessor vsg : this.virtualStorageGroupProcessor) {
+ if (vsg != null) {
+ ThreadUtils.stopThreadPool(vsg.getWALTrimScheduleTask(), ThreadName.WAL_TRIM);
Review comment:
Types are incompatible, please call getName() method like this:
```
ThreadUtils.stopThreadPool(vsg.getWALTrimScheduleTask(), ThreadName.WAL_TRIM.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #5090: [To rel/0.12][IOTDB-2567] Fix thread and ByteBuffer leak after service stopped
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #5090:
URL: https://github.com/apache/iotdb/pull/5090#discussion_r810063982
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/virtualSg/VirtualStorageGroupManager.java
##########
@@ -432,4 +434,12 @@ public void releaseWalDirectByteBufferPool() {
public void reset() {
Arrays.fill(virtualStorageGroupProcessor, null);
}
+
+ public void stopSchedulerPool() {
+ for (StorageGroupProcessor vsg : this.virtualStorageGroupProcessor) {
+ if (vsg != null) {
+ ThreadUtils.stopThreadPool(vsg.getWALTrimScheduleTask(), ThreadName.WAL_TRIM);
Review comment:
```suggestion
ThreadUtils.stopThreadPool(vsg.getWALTrimScheduleTask(), ThreadName.WAL_TRIM.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5090: [To rel/0.12][IOTDB-2567] Fix thread and ByteBuffer leak after service stopped
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5090:
URL: https://github.com/apache/iotdb/pull/5090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org