Re: [PR] IGNITE-22480 Sql. Avoid compiling literal-only expressions when assembling a row for insert [ignite-3]

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #3922:
URL: https://github.com/apache/ignite-3/pull/3922#discussion_r1644491001


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/ExpressionFactoryImpl.java:
##########
@@ -343,6 +345,17 @@ public Iterable<RowT> values(List<RexLiteral> values, RelDataType rowType) {
         return rows;
     }
 
+    private @Nullable Object literalValue(RexLiteral literal, Class<?> type) {
+        Object val = literal.getValueAs(type);
+
+        // Literal was parsed as UTC timestamp, now we need to adjust it to the client's time zone.
+        if (val != null && literal.getTypeName() == SqlTypeName.TIMESTAMP_WITH_LOCAL_TIME_ZONE) {

Review Comment:
   Should we adjust `TIME_WITH_LOCAL_TIME_ZONE` as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org