You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "birkskyum (via GitHub)" <gi...@apache.org> on 2024/09/17 09:22:29 UTC
[PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
birkskyum opened a new pull request, #30305:
URL: https://github.com/apache/superset/pull/30305
### SUMMARY
Part of:
- #28356
Modernizing the legacy-plugin-chart-map-box reduces the diff towards MapLibre.
This PR updates Supercluster from v4 to v8, which [improves performance and memory use](https://github.com/mapbox/supercluster/pull/223) for of this plugin.
### TESTING INSTRUCTIONS
- set the mapbox key in .env
- docker compose up
- open a mapbox chart, and it should still show clusters like below image
<img width="1726" alt="Screenshot 2024-09-17 at 11 15 56" src="https://github.com/user-attachments/assets/ca4b7a7e-5a43-4109-bafe-e6b0abbdf82e">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30305:
URL: https://github.com/apache/superset/pull/30305#issuecomment-2375772109
Tested, works great! Thanks, @birkskyum!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30305:
URL: https://github.com/apache/superset/pull/30305#issuecomment-2371894058
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30305:
URL: https://github.com/apache/superset/pull/30305#issuecomment-2371898001
@birkskyum to test/review these PRs, we typically need to check the plugin. There are a few ways to do this:
1) starting an ephemeral env here so anyone can test it (needs to be done by a committer)
2) pulling the change locally and running Superset (better in this case so we can add a mapbox key)
3) pulling the change locally and running Storybook
I'll start with #1 here before I approve. @mistercrunch was your review a code review, or did you test/validate the upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30305:
URL: https://github.com/apache/superset/pull/30305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #30305:
URL: https://github.com/apache/superset/pull/30305#issuecomment-2371909535
I only reviewed the 3 lines, seemed benign, didn't test locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(legacy-plugin-chart-map-box): bump supercluster to v8 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30305:
URL: https://github.com/apache/superset/pull/30305#issuecomment-2375772720
No idea why ephemeral environments aren't working again. Any ideas, @mistercrunch? Did those move to supersetbot or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org