You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/05/12 15:52:25 UTC
Review Request 34106: [WinTP2] Knox service need to be refactored due
to service check failed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34106/
-----------------------------------------------------------
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10911
https://issues.apache.org/jira/browse/AMBARI-10911
Repository: ambari
Description
-------
[WinTP2] Knox service need to be refactored due to service check failed
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml 5d32ce1
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py f3040ee
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py bc254c5
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py c96605e
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py d2a7983
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1347760
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 652094a
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 498e259
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py cf5ce2e
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py bdf4b04
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml feb8a00
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml 47c74c4
Diff: https://reviews.apache.org/r/34106/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [6.291s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.915s]
[INFO] Ambari Server ..................................... SUCCESS [1:29.086s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:39.843s
[INFO] Finished at: Tue May 12 06:45:35 PDT 2015
[INFO] Final Memory: 45M/216M
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 34106: [WinTP2] Knox service need to be refactored
due to service check failed
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34106/#review83459
-----------------------------------------------------------
Ship it!
Fix the typo, then ship it.
- Florian Barca
On May 12, 2015, 1:52 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34106/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 1:52 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10911
> https://issues.apache.org/jira/browse/AMBARI-10911
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Knox service need to be refactored due to service check failed
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml 5d32ce1
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py f3040ee
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py bc254c5
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py c96605e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py d2a7983
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1347760
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 652094a
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 498e259
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py cf5ce2e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py bdf4b04
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml feb8a00
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml 47c74c4
>
> Diff: https://reviews.apache.org/r/34106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [6.291s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.915s]
> [INFO] Ambari Server ..................................... SUCCESS [1:29.086s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.843s
> [INFO] Finished at: Tue May 12 06:45:35 PDT 2015
> [INFO] Final Memory: 45M/216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34106: [WinTP2] Knox service need to be refactored
due to service check failed
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34106/#review83548
-----------------------------------------------------------
Ship it!
Ship It!
- Florian Barca
On May 12, 2015, 7:52 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34106/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 7:52 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10911
> https://issues.apache.org/jira/browse/AMBARI-10911
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Knox service need to be refactored due to service check failed
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml 5d32ce1
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py f3040ee
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py bc254c5
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py c96605e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py d2a7983
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1347760
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 652094a
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 498e259
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py cf5ce2e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py bdf4b04
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml feb8a00
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml 47c74c4
>
> Diff: https://reviews.apache.org/r/34106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [6.291s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.915s]
> [INFO] Ambari Server ..................................... SUCCESS [1:29.086s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.843s
> [INFO] Finished at: Tue May 12 06:45:35 PDT 2015
> [INFO] Final Memory: 45M/216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 34106: [WinTP2] Knox service need to be refactored
due to service check failed
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34106/
-----------------------------------------------------------
(Updated Май 12, 2015, 7:52 п.п.)
Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
Bugs: AMBARI-10911
https://issues.apache.org/jira/browse/AMBARI-10911
Repository: ambari
Description
-------
[WinTP2] Knox service need to be refactored due to service check failed
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml 5d32ce1
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py f3040ee
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py bc254c5
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py c96605e
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py d2a7983
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1347760
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 652094a
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 498e259
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py cf5ce2e
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py bdf4b04
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml feb8a00
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml 47c74c4
Diff: https://reviews.apache.org/r/34106/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [6.291s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.915s]
[INFO] Ambari Server ..................................... SUCCESS [1:29.086s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:39.843s
[INFO] Finished at: Tue May 12 06:45:35 PDT 2015
[INFO] Final Memory: 45M/216M
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 34106: [WinTP2] Knox service need to be refactored
due to service check failed
Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34106/#review83458
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py
<https://reviews.apache.org/r/34106/#comment134450>
Cosmetic: Typo in knox_geteway_win_service_name, needs to be gateway, not geteway
- Florian Barca
On May 12, 2015, 1:52 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34106/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 1:52 p.m.)
>
>
> Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush Luniya.
>
>
> Bugs: AMBARI-10911
> https://issues.apache.org/jira/browse/AMBARI-10911
>
>
> Repository: ambari
>
>
> Description
> -------
>
> [WinTP2] Knox service need to be refactored due to service check failed
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/metainfo.xml 5d32ce1
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py f3040ee
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py bc254c5
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py c96605e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py d2a7983
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 1347760
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 652094a
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py 498e259
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_mapping.py cf5ce2e
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py bdf4b04
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/knox-env.xml feb8a00
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/KNOX/configuration/ranger-knox-plugin-properties.xml 47c74c4
>
> Diff: https://reviews.apache.org/r/34106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [6.291s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.915s]
> [INFO] Ambari Server ..................................... SUCCESS [1:29.086s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:39.843s
> [INFO] Finished at: Tue May 12 06:45:35 PDT 2015
> [INFO] Final Memory: 45M/216M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>