You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "msyavuz (via GitHub)" <gi...@apache.org> on 2026/06/18 11:01:32 UTC
[PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
msyavuz opened a new pull request, #41197:
URL: https://github.com/apache/superset/pull/41197
### SUMMARY
`uv` already drives Python dependency compilation (`uv pip compile` via `scripts/uv-pip-compile.sh`) and every install site in CI and Docker (`setup-backend`, `Dockerfile`, `docker/pip-install.sh`). A few raw-`pip` call sites were left behind; this swaps them to the `uv pip` compatibility interface so the toolchain is consistent.
Changed call sites:
- **Makefile** — `superset`, `update-py`, `pre-commit` targets (bootstraps `uv` into the active venv, then `uv pip install`)
- **CI** — `bashlib.sh` (`testdata` / `playwright_testdata`), `superset-app-cli`, `superset-python-presto-hive`
No change to `requirements/*.txt` or `pyproject.toml` — this is the drop-in `uv pip` interface only, not a move to `uv.lock`/`uv sync`. CI sites already have `uv` installed system-wide via `setup-backend`, so they use `--system`. The intentional `command -v uv` fallbacks in `docker/docker-bootstrap.sh` (for older images) are left in place.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — build/CI tooling only, no UI.
### TESTING INSTRUCTIONS
- `make -n superset` / `make -n update-py` / `make -n pre-commit` show `uv pip install`.
- E2E, app-cli, and presto-hive CI jobs build the editable package via `uv pip install --system -e .` and pass.
- `bash -n .github/workflows/bashlib.sh` is clean.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI — No, build/CI tooling only.
- [ ] Includes DB Migration — No.
- [ ] Introduces new feature or API — No.
- [ ] Removes existing feature or API — No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41197:
URL: https://github.com/apache/superset/pull/41197#issuecomment-4741304851
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 4c947dff1370d15267b300566a19f47c4a25cfdb |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a33d00c505fcc0008dacf0a |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41197--superset-docs-preview.netlify.app](https://deploy-preview-41197--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBCoAgEADAv-w5cUGM6Ac9Y1sThdTFMqjo73mbw7wgtSQ5YQYYYK2UOXSn46arPZpDqZtul5Ioysccj9Cb22Qv9-J6HMkYh8gWrWdGxMkReyT4fg) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-41197--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #41197:
URL: https://github.com/apache/superset/pull/41197#issuecomment-4756313752
LGTM. Great work @msyavuz!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41197:
URL: https://github.com/apache/superset/pull/41197#issuecomment-4741370667
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41197?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.55%. Comparing base ([`664e777`](https://app.codecov.io/gh/apache/superset/commit/664e777a8498db70cdc9735ef6c701f910864470?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4c947df`](https://app.codecov.io/gh/apache/superset/commit/4c947dff1370d15267b300566a19f47c4a25cfdb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 39 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #41197 +/- ##
==========================================
- Coverage 64.31% 63.55% -0.76%
==========================================
Files 2652 2652
Lines 144819 144853 +34
Branches 33428 33435 +7
==========================================
- Hits 93142 92067 -1075
- Misses 50010 51113 +1103
- Partials 1667 1673 +6
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.32% <ø> (-0.01%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.46% <ø> (+<0.01%)` | :arrow_up: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.91% <ø> (+<0.01%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.95% <ø> (-1.62%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.78% <ø> (+<0.01%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/41197/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41197?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41197:
URL: https://github.com/apache/superset/pull/41197#issuecomment-4741286301
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): finish pip→uv swap in Makefile and CI [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #41197:
URL: https://github.com/apache/superset/pull/41197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org