[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5209: [Feature] Support Create Dynamic Partition Immediately FirstTime Without Wating Schedule.

[GitBox <gi...@apache.org>]

yangzhg commented on a change in pull request #5209:
URL: https://github.com/apache/incubator-doris/pull/5209#discussion_r553770477



##########
File path: fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
##########
@@ -248,15 +254,14 @@ public void createOrUpdateRuntimeInfo(String tableName, String key, String value
         return dropPartitionClauses;
     }
 
-    private void executeDynamicPartition() {
-        Iterator<Pair<Long, Long>> iterator = dynamicPartitionTableInfo.iterator();
-        while (iterator.hasNext()) {
-            Pair<Long, Long> tableInfo = iterator.next();
+    private void executeDynamicPartition(Iterator<Pair<Long, Long>> tableInfoIterator) {

Review comment:
       I think use List is better




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org