You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/21 23:40:53 UTC

[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #507: [YUNIKORN-1492] Add gang scheduling test suites

wilfred-s commented on PR #507:
URL: https://github.com/apache/yunikorn-k8shim/pull/507#issuecomment-1362223246

   I understand that this is still a draft but these comments should be solved before moving out of draft stage:
   * license headers for all files
   * no filenames with capitals (Wrappers.go)
   * sort imports in 3 groups based on origin: golang system, others packages and yunikorn package imports
   * Remove any company specific info or messages


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org