You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/06 13:33:08 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
liugddx opened a new pull request, #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
refactor jupiter,add junit-jupiter-api
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1240222025
I checked the `junit-bom`, which contains only junit dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1239392730
revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1239301378
This PR contains the reason: https://github.com/apache/incubator-seatunnel/pull/2672 . I ran CI again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238236966
the e2e module used junit 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238860107
>  In which dependency will `junit-jupiter-api-5.8.2` be referenced?
i dependence `spring-boot-dependencies`,and the `junit-jupiter.version`is 5.8.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238284417
Occasionally switching branches leads to inconsistent versions of api dependencies
<img width="738" alt="ecfb805b4e601305b5f182eee5db365" src="https://user-images.githubusercontent.com/48236177/188667051-9542fefe-89ed-4b2c-86c1-0781b6e79808.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238812860
> I think we have declared these dependencies, `junit-jupiter-params` inculde `juitper-api` if you checked. e2e We use junit4 and 5 for `Testcontainers` reasons
but the e2e dependence `jupiter`.if the `junit-jupiter-api` has a different versions.the error will happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
liugddx commented on code in PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#discussion_r964318429
##########
pom.xml:
##########
@@ -256,13 +256,20 @@
<artifactId>commons-collections4</artifactId>
<version>${commons-collections4.version}</version>
</dependency>
-
+
<dependency>
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
<version>${jcommander.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
It's probably because I switched branches，but strong dependence is not better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1239383823
hi, we better revert https://github.com/apache/incubator-seatunnel/blob/34ccfd7a2cd93d8dc0d3f6bb1e1afebcc9761a9e/pom.xml#L360
This modification changes so many dependencies that I suspect there are still a lot of potential issues that haven't been discovered, but as long as we revert it, this issue and other issues can be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#discussion_r964314563
##########
pom.xml:
##########
@@ -256,13 +256,20 @@
<artifactId>commons-collections4</artifactId>
<version>${commons-collections4.version}</version>
</dependency>
-
+
<dependency>
<groupId>com.beust</groupId>
<artifactId>jcommander</artifactId>
<version>${jcommander.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
`junit-jupiter-engine` contains `junit-jupiter-api`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1240180914
My suggestion is to introduce junit-bom for dependency management and remove `junit-jupiter-engine` and `junit-jupiter-params` with the following changes:
add:
```
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>${junit.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
```
remote:
```
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>${junit.version}</version>
<scope>test</scope>
</dependency>
```
update:
```
<dependencies>
...
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#discussion_r965528678
##########
pom.xml:
##########
@@ -178,7 +178,7 @@
<skipUT>false</skipUT>
<skipIT>true</skipIT>
<elasticsearch>7</elasticsearch>
- <slf4j.version>1.7.25</slf4j.version>
+ <slf4j.version>1.7.36</slf4j.version>
Review Comment:
slf4j-log4j12-1.7.36 will not include log4j.
```suggestion
<slf4j.version>1.7.25</slf4j.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1240183195
UserControllerTest executes an error after the scheduler function is added to the web module, because the web module needs to connect to the dolphinscheduler server, I will deal with this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238165340
Can you explain why you want to add this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1238825585
In which dependency will `junit-jupiter-api-5.8.2` be referenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1239400310
You need to revert the dependency changes in #2506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org