You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "rivasj (GitHub)" <gi...@apache.org> on 2018/08/22 16:24:20 UTC

[GitHub] [trafficcontrol] rivasj opened pull request #2739: Traffic Monitor formatting - go fmt

#### What does this PR do?

- formats TM code using 'go fmt'

Fixes #(issue_number)

#### Which TC components are affected by this PR?

- [ ] Documentation
- [ ] Grove
- [ ] Traffic Analytics
- [x] Traffic Monitor
- [ ] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] Other _________

#### What is the best way to verify this PR?

- there are no functional changes to verify, only formatting

#### Check all that apply

- [ ] This PR includes tests
- [ ] This PR includes documentation updates
- [ ] This PR includes an update to CHANGELOG.md
- [x] This PR includes all required license headers
- [x] This PR does *NOT* fix a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)

<!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
-->





[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [trafficcontrol] dangogh closed pull request #2739: Traffic Monitor formatting - go fmt

Posted by "dangogh (GitHub)" <gi...@apache.org>.
[ pull request closed by dangogh ]

[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [trafficcontrol] asfgit commented on issue #2739: Traffic Monitor formatting - go fmt

Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/trafficcontrol-PR/2312/
Test PASSed.


[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [trafficcontrol] rivasj commented on pull request #2739: Traffic Monitor formatting - go fmt

Posted by "rivasj (GitHub)" <gi...@apache.org>.
done!

[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [trafficcontrol] asfgit commented on issue #2739: Traffic Monitor formatting - go fmt

Posted by "asfgit (GitHub)" <gi...@apache.org>.
Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/trafficcontrol-PR/2311/
Test PASSed.


[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [trafficcontrol] dangogh commented on pull request #2739: Traffic Monitor formatting - go fmt

Posted by "dangogh (GitHub)" <gi...@apache.org>.
since we're reordering anyway,  can you move the "sync" to the top with a blank line after it?  go fmt will keep the std library separate from the rest that way -- same with the file below..

[ Full content available at: https://github.com/apache/trafficcontrol/pull/2739 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org