Re: [PR] style(sqllab): restore Template Parameters modal styling [superset]

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #35965:
URL: https://github.com/apache/superset/pull/35965#discussion_r2804597495


##########
superset-frontend/src/SqlLab/components/TemplateParamsEditor/index.tsx:
##########
@@ -64,13 +72,11 @@ const TemplateParamsEditor = ({
 
   const modalBody = (
     <div>
-      <p>
-        {t('Assign a set of parameters as')}
-        <code>JSON</code>
-        {t('below (example:')}
-        <code>{'{"my_table": "foo"}'}</code>
-        {t('), and they become available in your SQL (example:')}
-        <code>SELECT * FROM {'{{ my_table }}'} </code>) {t('by using')}&nbsp;
+      <StyledParagraph>
+        {t('Assign a set of parameters as')} <Code>JSON</Code>{' '}
+        {t('below (example:')} <Code>{'{"my_table": "foo"}'}</Code>
+        {t('), and they become available in your SQL (example:')}{' '}
+        <Code>SELECT * FROM {'{{ my_table }}'} </Code>) {t('by using')}&nbsp;

Review Comment:
   We should use a library like `react-i18next` so we can write this as:
   
   ```typescript
   <Trans i18nKey="assignParams">
     Assign a set of parameters as <Code>JSON</Code> below (example:
     <Code>{"{\"my_table\": \"foo\"}"}</Code>), and they become available
     in your SQL (example: <Code>SELECT * FROM {{ my_table }}</Code>)
     by using
   </Trans>
   ```
   
   Because as-is the translation strings are too dependent on English, and translators don't have the full context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org