You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/10/16 15:43:58 UTC
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/560
unify jshint and jscs
use the modern eslint to replace jshint and jscs
pros:
- faster checks and boot of the devserver as everything is done in one run
- style testing for jsx files
this prepares react 14 and babel :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton babel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #560
----
commit bdc286e065b0a8287c5a91ae92c20c19e6ffd3b1
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T12:36:11Z
fix missing semicolons and style
commit 2b51ad93335442dd8babe3637adea9e29ca11aa2
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T12:56:01Z
fix comma spacing
commit 4b9b6f56fb3359916ba058dc4bf49b626e2bf5ce
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T13:07:42Z
semicolon spacing
commit 1abf41abea1aa65d48077af9b253bd1d447f6014
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T13:34:06Z
unify jshint and jscs
use the modern eslint to replace jshint and jscs
- faster checks as everything is done in one run
- style testing for jsx files
commit a046002de3fc2777c899c154b6020fbf9f947792
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T13:39:21Z
fix jsx style issues
commit 2faace08fe815c0fd496ed72c4ce3249d6d9f7f3
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-10-16T13:39:33Z
enable react stylechecks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/560#issuecomment-148778314
+1 great work! No problems at all, and it's nice and zippy now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/560#issuecomment-149152665
merged as:
42b9fa4069e5fa17df61c2feea171bf3657642d3
d2d98bd9a9d3ea355daaa386270eec5adb210e1e
1d8569f126e1f1818b3d6bc868f7ff53fe771111
3e86afa138ec54c942f64a281d6001bde324a200
44a476fc5ce8aef55460849a323425c6c15e8fe1
901d0060f7c1acff0b1b9cec50da4b6c157a36b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/560#issuecomment-148721571
note: we test a few more files now and our jsx is now tested, too so i had to make a few style fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/560
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: unify jshint and jscs
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/560#issuecomment-148721982
note: run npm install to install eslint
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---