[GitHub] [solr-operator] HoustonPutman commented on issue #282: Allow changing the livenessPrope settings for prometheus exporter

[GitBox <gi...@apache.org>]

HoustonPutman commented on issue #282:
URL: https://github.com/apache/solr-operator/issues/282#issuecomment-879994152


   Thanks for suggesting this @benediktarnold , and especially backing it up with such clear results.
   
   I think that adding support for changing all the probes for the PrometheusExporter is a no-brainer, and should be very simple to do. But if the performance using the default probes is this bad, we should probably look at options for changing the default behavior as well.
   
   Maybe one solution is to add an actual health-check handler to the PrometheusExporter itself (in Solr), that just checks that the metrics cache is healthy, and the jetty server responds.
   
   A second question, what version of the prometheus exporter are you using? It seems weird to me that additional calls to `/metrics` would be that expensive, given that all the metrics _should_ be cached in the first place. Maybe it's very expensive to generate the long response?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org