[GitHub] [ozone] symious commented on a diff in pull request #3875: HDDS-7183. Expose RocksDB critical properties.

["symious (via GitHub)" <gi...@apache.org>]

symious commented on code in PR #3875:
URL: https://github.com/apache/ozone/pull/3875#discussion_r1117125884


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreMBean.java:
##########
@@ -179,6 +234,7 @@ public void getMetrics(MetricsCollector metricsCollector, boolean b) {
     MetricsRecordBuilder rb = metricsCollector.addRecord(contextName);
     getHistogramData(rb);
     getTickerTypeData(rb);
+    getDBPropertyData(rb);

Review Comment:
   I'm not sure about this.
   
   I reckon the default value of "ozone.metastore.rocksdb.statistics" was set to "false" because of some performance impact. But since the newly added metrics don't have such impacts, I think it's better to have these metrics exposed by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org