You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/05/20 03:19:11 UTC

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15964


Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................

IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

On GCC7, a dangling-else warning is firing for code like:

if (cond1) ASSERT_TRUE(cond2)

This is true for several ASSERT_* and EXPECT_* gtest macros.
gtest had some code to avoid warnings for code of this form,
but that code is no longer effective. gtest now disables
the dangling-else warning. Since this is just a matter of
adding braces, this adds braces for all those locations.
For consistency, this may include locations that were not
failing. I found locations by doing:
git grep EXPECT_ | grep if
git grep ASSERT_ | grep if
and manually looking through the output.

Testing:
 - Builds successfully

Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
---
M be/src/exec/parquet/parquet-common-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/testutil/cpu-util.h
6 files changed, 29 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/15964/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................

IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

On GCC7, a dangling-else warning is firing for code like:

if (cond1) ASSERT_TRUE(cond2)

This is true for several ASSERT_* and EXPECT_* gtest macros.
gtest had some code to avoid warnings for code of this form,
but that code is no longer effective. gtest now disables
the dangling-else warning. Since this is just a matter of
adding braces, this adds braces for all those locations.
For consistency, this may include locations that were not
failing. I found locations by doing:
git grep EXPECT_ | grep if
git grep ASSERT_ | grep if
and manually looking through the output.

Testing:
 - Builds successfully

Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Reviewed-on: http://gerrit.cloudera.org:8080/15964
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-common-test.cc
M be/src/runtime/buffered-tuple-stream-test.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/timestamp-test.cc
M be/src/testutil/cpu-util.h
6 files changed, 29 insertions(+), 11 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Wed, 27 May 2020 23:29:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5902/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 28 May 2020 20:32:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 1:

Thanks for the review, going ahead with GVO


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2020 20:32:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 01:57:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6111/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 May 2020 03:55:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15964 )

Change subject: IMPALA-9761: Fix GCC7 ambiguous else warning for gtest macros
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb664afe83736a71508302575e8e66a1b506c985
Gerrit-Change-Number: 15964
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Thu, 28 May 2020 20:32:16 +0000
Gerrit-HasComments: No