[GitHub] [apisix] spacewander commented on a diff in pull request #7168: fix(proxy-cache): allow nil ctx vars in cache key

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #7168:
URL: https://github.com/apache/apisix/pull/7168#discussion_r886356785


##########
docs/en/latest/plugins/proxy-cache.md:
##########
@@ -53,6 +53,10 @@ The cache expiration time cannot be configured dynamically. It can only be set b
 
 If the Upstream service is not available and APISIX returns a 502 or 504 status code, it will be cached for 10s.
 
+Variables (start with `$`) can be specified in `cache_key`, `cache_bypass` and `no_cache`. It's worth to mention that the variable value will be an empty string if it doesn't exist.

Review Comment:
   ```suggestion
   Variables (start with `$`) can be specified in `cache_key`, `cache_bypass` and `no_cache`. It's worth mentioning that the variable value will be an empty string if it doesn't exist.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org