[GitHub] [spark] peter-toth edited a comment on pull request #31550: [SPARK-34421][SQL] Resolve temporary functions and views in views with CTEs

[GitBox <gi...@apache.org>]

peter-toth edited a comment on pull request #31550:
URL: https://github.com/apache/spark/pull/31550#issuecomment-781229308


   So it looks like the test case caused a bit of confusion here so I've split it into 2 cases.
   - `SPARK-34421: Resolve temporary objects in temporary views with CTEs` tests the regression part due to https://github.com/apache/spark/pull/30567. Please note that the temp view in temp view part does work even without this fix and the bug affects only the temp function in temp view case. Permanent functions are not affected and the code change modifies `collectTemporaryObjects` only. 
   - `SPARK-34421: Resolve temporary objects in permanent views with CTEs` tests the non regression part. That "temp object in permanent one" check came with https://github.com/apache/spark/pull/30567 but it doesn't work on permanent views with CTEs without this fix. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org