You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/07 02:25:49 UTC
[kudu-CR] catalog manager: various boring cleanup
Hello Dan Burkert, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7990
to review the following change.
Change subject: catalog_manager: various boring cleanup
......................................................................
catalog_manager: various boring cleanup
Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 49 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7990/1
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] catalog manager: various boring cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 3766: committer_out.AddTablets({ new_tablet });
> std::move(new_tablet)
Done
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] catalog manager: various boring cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 3766: committer_out.AddTablets({ new_tablet });
std::move(new_tablet)
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] catalog manager: various boring cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 2489: const string delete_msg = report_opid_index == consensus::kInvalidOpIdIndex ?
> That's https://github.com/apache/kudu/commit/cd6eee7a375e053f1f9bed338e603b
oh sorry, should have recognized that.
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] catalog manager: various boring cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7990
to look at the new patch set (#2).
Change subject: catalog_manager: various boring cleanup
......................................................................
catalog_manager: various boring cleanup
Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 51 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7990/2
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] catalog manager: various boring cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: catalog_manager: various boring cleanup
......................................................................
catalog_manager: various boring cleanup
Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Reviewed-on: http://gerrit.cloudera.org:8080/7990
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 51 insertions(+), 37 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] catalog manager: various boring cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 2489: const string delete_msg = report_opid_index == consensus::kInvalidOpIdIndex ?
> Is this a bug fix? Seems the behavior is slightly different.
That's https://github.com/apache/kudu/commit/cd6eee7a375e053f1f9bed338e603bf9ca91e709; I merely rebase on top of it. If you look at the Base-->PS3 diff, you won't see any changes here.
I don't actually know the answer to your question; best to ask Andrew or Mike.
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] catalog manager: various boring cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7990
to look at the new patch set (#3).
Change subject: catalog_manager: various boring cleanup
......................................................................
catalog_manager: various boring cleanup
Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 51 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/7990/3
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] catalog manager: various boring cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: catalog_manager: various boring cleanup
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 2489: const string delete_msg = report_opid_index == consensus::kInvalidOpIdIndex ?
Is this a bug fix? Seems the behavior is slightly different.
--
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes