[jira] [Commented] (SOLR-7458) Expose HDFS Block Locality Metrics

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523102#comment-14523102 ] 

Mark Miller commented on SOLR-7458:
-----------------------------------

This looks like a good approach.

bq. localhost = System.getProperty("solr.host", "localhost");

This looks off to me. For one, I'm wary of using 'localhost' vs 127.0.0.1. Are we sure that is the right approach?

Also, 'solr.host' is not any kind of official system property. There is a host property in solr.xml.

bq. private final Map<HdfsDirectory,Map<FileStatus,BlockLocation[]>> cache

This cache needs to be thread safe.

> Expose HDFS Block Locality Metrics
> ----------------------------------
>
>                 Key: SOLR-7458
>                 URL: https://issues.apache.org/jira/browse/SOLR-7458
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Mike Drob
>            Assignee: Mark Miller
>              Labels: metrics
>         Attachments: SOLR-7458.patch, SOLR-7458.patch
>
>
> We should publish block locality metrics when using HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org