[GitHub] spark pull request #21236: [SPARK-23935][SQL] Adding map_entries function

[mn-mikke <gi...@git.apache.org>]

Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21236#discussion_r207148777
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala ---
    @@ -98,6 +98,9 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks {
             if (expected.isNaN) result.isNaN else expected == result
           case (result: Float, expected: Float) =>
             if (expected.isNaN) result.isNaN else expected == result
    +      case (result: UnsafeRow, expected: GenericInternalRow) =>
    --- End diff --
    
    Hi @srowen,
    ```(InternalRow, InternalRow)``` case was introduced later in [21838](https://github.com/apache/spark/pull/21838) and covers the logic of the case with ```UnsafeRow```. So we can just remove the unreachable piece of code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org