You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/18 12:32:17 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #5333: vmware: delete snapshot disk after backup to secondary storage
rhtyd opened a new pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333
Currently, when volume snapshots are taken the snapshot/vmdk is not removed on primary storage for VMware. Without the fix, primary storage can fill very fast.
WIP - This ensures that worker VM is destroyed along with any of its own
disks that are backed up to secondary storage.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907360425
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906596392
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r697159532
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1848,14 +1848,15 @@ public Answer createTemplateFromSnapshot(CopyCommand cmd) {
s_logger.error(msg);
throw new Exception(msg);
}
+ s_logger.debug(String.format("Cloned VM: %s as %s", vmMo.getName(), clonedVm.getName()));
vmMo = clonedVm;
}
vmMo.exportVm(exportPath, exportName, false, false);
return new Pair<>(diskDevice, disks);
} finally {
if (clonedVm != null) {
- clonedVm.detachAllDisks();
+ s_logger.debug(String.format("Destroying cloned VM: %s with its disks", clonedVm.getName()));
Review comment:
@shwstppr Thanks for the fix, the same fix applies in the flow of creating template from volume. Can you please fix it there as well https://github.com/apache/cloudstack/blob/cb1078aa202ef77cd699a7617daf006febb6fee6/plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java#L1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r699002144
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1241,6 +1241,7 @@ private void postCreatePrivateTemplate(String installFullPath, long templateId,
ManagedObjectReference morPool = hyperHost.getHyperHostOwnerResourcePool();
vmMo.createFullCloneWithSpecificDisk(templateUniqueName, dcMo.getVmFolder(), morPool, VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()), volumeDeviceInfo);
clonedVm = dcMo.findVm(templateUniqueName);
+ s_logger.debug(String.format("Cloned VM: %s as %s", vmMo.getName(), clonedVm.getName()));
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911216338
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906595835
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911216705
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908920932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911969153
<b>Trillian test result (tid-1931)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36639 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1931-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906620421
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911201854
Lgtm, thanks for picking up the PR @shwstppr
Failures not related to this PR.
@sureshanaparti @harikrishna-patnala are you lgtm on changes, do we need it further testing. Or additional testing than you've done @shwstppr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-910310493
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908966665
Ping @harikrishna-patnala @sureshanaparti do we keep this or close this in favour of some other PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911206808
@shwstppr can you resolve conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r691197750
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2025,7 +2025,6 @@ public Answer backupSnapshot(CopyCommand cmd) {
try {
if (workerVm != null) {
// detach volume and destroy worker vm
- workerVm.detachAllDisks();
Review comment:
@harikrishna-patnala can you check if per the new code/manager, we should detach the worker VM's disks after the backup of snapshot to secondary storage passes?
cc @nvazquez @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r697161011
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1848,14 +1848,15 @@ public Answer createTemplateFromSnapshot(CopyCommand cmd) {
s_logger.error(msg);
throw new Exception(msg);
}
+ s_logger.debug(String.format("Cloned VM: %s as %s", vmMo.getName(), clonedVm.getName()));
vmMo = clonedVm;
}
vmMo.exportVm(exportPath, exportName, false, false);
return new Pair<>(diskDevice, disks);
} finally {
if (clonedVm != null) {
- clonedVm.detachAllDisks();
+ s_logger.debug(String.format("Destroying cloned VM: %s with its disks", clonedVm.getName()));
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911381308
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908921337
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911217860
<b>Trillian test result (tid-1911)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40892 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1911-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911223489
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907577764
<b>Trillian test result (tid-1815)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42171 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1815-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901597507
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901597215
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r697148604
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2025,7 +2025,6 @@ public Answer backupSnapshot(CopyCommand cmd) {
try {
if (workerVm != null) {
// detach volume and destroy worker vm
- workerVm.detachAllDisks();
Review comment:
Change made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901617055
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908933676
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901619174
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976250
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976865
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-909687821
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901619300
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-909687821
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907360701
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911380902
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r691848684
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2025,7 +2025,6 @@ public Answer backupSnapshot(CopyCommand cmd) {
try {
if (workerVm != null) {
// detach volume and destroy worker vm
- workerVm.detachAllDisks();
Review comment:
verified the issue and is reproducible. We need to delete the cloned VM completely including disks, not the worker VM (worker VM has the actual disk attached to it). Also there is another place to fix. I'll fix and update this PR. Thanks @rhtyd for drafting this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911258860
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911210323
> Lgtm, thanks for picking up the PR @shwstppr
> Failures not related to this PR.
> @sureshanaparti @harikrishna-patnala are you lgtm on changes, do we need it further testing. Or additional testing than you've done @shwstppr?
@rhtyd this PR should cover tests for create volume snapshot and create template from snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908966665
Ping @harikrishna-patnala @sureshanaparti do we keep this or close this in favour of some other PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908934100
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r698281399
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
```suggestion
VirtualMachineMO importedVm = null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r700764799
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907114300
There may be related PR, @sureshanaparti @harikrishna-patnala can you check and advise if I should close it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906610773
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-902092372
<b>Trillian test result (tid-1710)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40854 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1710-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn | `Failure` | 261.94 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908921337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906901563
<b>Trillian test result (tid-1786)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34147 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1786-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911221854
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911216705
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r699002144
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1241,6 +1241,7 @@ private void postCreatePrivateTemplate(String installFullPath, long templateId,
ManagedObjectReference morPool = hyperHost.getHyperHostOwnerResourcePool();
vmMo.createFullCloneWithSpecificDisk(templateUniqueName, dcMo.getVmFolder(), morPool, VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()), volumeDeviceInfo);
clonedVm = dcMo.findVm(templateUniqueName);
+ s_logger.debug(String.format("Cloned VM: %s as %s", vmMo.getName(), clonedVm.getName()));
Review comment:
Done
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
I feel `workerVm` suits more here as we use the VM just to import the OVF created for volume that is to be restored from sec store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r698269238
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1241,6 +1241,7 @@ private void postCreatePrivateTemplate(String installFullPath, long templateId,
ManagedObjectReference morPool = hyperHost.getHyperHostOwnerResourcePool();
vmMo.createFullCloneWithSpecificDisk(templateUniqueName, dcMo.getVmFolder(), morPool, VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()), volumeDeviceInfo);
clonedVm = dcMo.findVm(templateUniqueName);
+ s_logger.debug(String.format("Cloned VM: %s as %s", vmMo.getName(), clonedVm.getName()));
Review comment:
@shwstppr can you move this log before this return stmt (in _createFullCloneWithSpecificDisk() @ VirtualMachineMO_):
https://github.com/apache/cloudstack/blob/04738d7775fac382250932f44c7e2cb44a54617c/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java#L782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-910310951
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906976127
@harikrishna-patnala @sureshanaparti made the change for volume to template export.
Also, renamed a confusing variable for restore volume case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908920932
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-909689062
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-901642100
@harikrishna-patnala pl carry on any further fixing, changes around the bug, treat this as a proof of concept fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r691197750
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2025,7 +2025,6 @@ public Answer backupSnapshot(CopyCommand cmd) {
try {
if (workerVm != null) {
// detach volume and destroy worker vm
- workerVm.detachAllDisks();
Review comment:
@harikrishna-patnala can you check if per the new code/manager, we should detach the worker VM's disks after the backup of snapshot to secondary storage passes?
cc @nvazquez @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-909689062
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-906620706
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-907002123
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-908932446
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-911216338
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#issuecomment-910689557
<b>Trillian test result (tid-1879)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 76123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5333-t1879-vmware-67u3.zip
Smoke tests completed. 88 look OK, 3 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_deploy_vm_start_failure | `Error` | 132.01 | test_deploy_vm.py
test_deploy_vm_volume_creation_failure | `Error` | 111.19 | test_deploy_vm.py
test_vm_ha | `Error` | 81.15 | test_vm_ha.py
test_vm_sync | `Error` | 187.35 | test_vm_sync.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r699002941
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
I feel `workerVm` suits more here as we use the VM just to import the OVF created for volume that is to be restored from sec store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r700758944
##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -3764,24 +3766,24 @@ private Long restoreVolumeFromSecStorage(VmwareHypervisorHost hyperHost, Datasto
throw new Exception(msg);
}
- VirtualMachineMO clonedVm = null;
+ VirtualMachineMO workerVm = null;
Review comment:
@shwstppr If this is a worker VM, please tag it accordingly so that it can be tracked (when not destroyed, in failed scenarios) and cleaned up when worker vms cleanup is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org