You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/14 10:01:32 UTC
[GitHub] [activemq-artemis] MrEasy opened a new pull request #3795: ARTEMIS-2618 Added optional retry handling on critical I/O Error
MrEasy opened a new pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795
This can be used if running in environments where external applications temporarily lock journal files (e.g. virus scanners).
Disabled by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] MrEasy commented on pull request #3795: ARTEMIS-2618 Added optional retry handling on critical I/O Error
Posted by GitBox <gi...@apache.org>.
MrEasy commented on pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1032302190
Can't argue with that of course.
As you can see in the issue though, it has its 2nd birthday in 2 days :-) - so would prefer not investing more time if that then would not result in sth. releasable.
Do you think the points you mentioned are the ones that should complete it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3795: ARTEMIS-2618 Added optional retry handling on critical I/O Error
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1040657904
> Do you think the points you mentioned are the ones that should complete it?
I can't speak for anyone else, but as far as I'm concerned I would say yes at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3795: ARTEMIS-2618 Added optional retry handling on critical I/O Error
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1031694156
This idea has merit, but there a couple problems:
- The code isn't formatted properly so CheckStyle is failing.
- The retry is limited to `org.apache.activemq.artemis.core.io.nio.NIOSequentialFile#open(int, boolean)`, but there are several implementations of `org.apache.activemq.artemis.core.io.SequentialFile#open(int, boolean)` which might benefit from such a retry.
- The configuration should be available from `broker.xml` rather than just a system property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org