You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/29 06:58:23 UTC
[GitHub] [spark] LuciferYang opened a new pull request #30179: [SPARK-12667][CORE][FOLLOWUP] Remove useless externalBlockStoreSize from RDDInfo
LuciferYang opened a new pull request #30179:
URL: https://github.com/apache/spark/pull/30179
### What changes were proposed in this pull request?
"external block store" API was removed after SPARK-12667, `externalBlockStoreSize` in `RDDInfo` looks like always 0 and useless. So this pr just to remove this useless variable.
### Why are the changes needed?
remove useless variable.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass the Jenkins or GitHub Action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718417244
@HyukjinKwon ok ~ keep the mima ~ thx ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718414089
@HyukjinKwon done, use this pr or need re-submit one? EDIT: SPARK-33283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30179: [SPARK-12667][CORE][FOLLOWUP] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718405175
**[Test build #130396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130396/testReport)** for PR 30179 at commit [`a9e5fc0`](https://github.com/apache/spark/commit/a9e5fc025187b7f6576bd73e03dfc1e0cfd87f1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718462799
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34999/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-719128441
thx @dongjoon-hyun and @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30179:
URL: https://github.com/apache/spark/pull/30179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718462850
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34999/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #30179: [SPARK-12667][CORE][FOLLOWUP] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718408887
@dongjoon-hyun I'm not sure if line 1294 in `MimaExcludes` should also be deleted
https://github.com/apache/spark/blob/9d5e48ea95d1c3017a51ff69584f32a18901b2b5/project/MimaExcludes.scala#L1294
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718538712
**[Test build #130396 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130396/testReport)** for PR 30179 at commit [`a9e5fc0`](https://github.com/apache/spark/commit/a9e5fc025187b7f6576bd73e03dfc1e0cfd87f1d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718443484
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34999/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30179:
URL: https://github.com/apache/spark/pull/30179#discussion_r514327006
##########
File path: core/src/main/scala/org/apache/spark/rdd/RDD.scala
##########
@@ -1919,9 +1919,8 @@ abstract class RDD[T: ClassTag](
val persistence = if (storageLevel != StorageLevel.NONE) storageLevel.description else ""
val storageInfo = rdd.context.getRDDStorageInfo(_.id == rdd.id).map(info =>
- " CachedPartitions: %d; MemorySize: %s; ExternalBlockStoreSize: %s; DiskSize: %s".format(
- info.numCachedPartitions, bytesToString(info.memSize),
- bytesToString(info.externalBlockStoreSize), bytesToString(info.diskSize)))
+ " CachedPartitions: %d; MemorySize: %s; DiskSize: %s".format(
+ info.numCachedPartitions, bytesToString(info.memSize), bytesToString(info.diskSize)))
Review comment:
Since it was removed at `toString`, it's okay to remove it from `toDebugString`.
- https://github.com/apache/spark/pull/10752/files#diff-e49db126594e91593208902e13961dc09524442090801f4d6cfce7c43da13c72R42-R48
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718462842
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718414089
@HyukjinKwon done, reuse this pr or need re-submit one? EDIT: SPARK-33283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718542207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718414089
@HyukjinKwon done, use this pr or need re-submit one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718405175
**[Test build #130396 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130396/testReport)** for PR 30179 at commit [`a9e5fc0`](https://github.com/apache/spark/commit/a9e5fc025187b7f6576bd73e03dfc1e0cfd87f1d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30179: [SPARK-12667][CORE][FOLLOWUP] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718410542
@LuciferYang, can you open a separate JIRA to manage separately? e.g.) fixed versions should be set differently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718462842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718542207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30179: [SPARK-33283][CORE] Remove useless externalBlockStoreSize from RDDInfo
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30179:
URL: https://github.com/apache/spark/pull/30179#issuecomment-718416399
I believe we should keep the mima. They are removed signatures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org