You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/05/11 16:41:07 UTC
Review Request 34041: LENS-548 : Remove no-prefix and -p0 from
contribute doc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34041/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Remove no-prefix and -p0 from contribute doc
Diffs
-----
src/site/apt/developer/contribute.apt 821ddab
Diff: https://reviews.apache.org/r/34041/diff/
Testing
-------
Thanks,
Yash Sharma
Re: Review Request 34041: LENS-548 : Remove no-prefix and -p0 from
contribute doc
Posted by Yash Sharma <ya...@gmail.com>.
> On May 12, 2015, 5:06 a.m., Amareshwari Sriramadasu wrote:
> > Please test the document by running mvn site:run and checkinf http://localhost:8080 - as documented here - http://lens.incubator.apache.org/developer/contribute.html#How_to_update_documentation
> >
> > Yash,
> > Few suggestions for the review request :
> >
> > - Can you link bugs field when you raise a review request? That will allow to click on the link and look at the bug if more details need to be looked up.
> > - We are following uploading the patch to jira ofter final "ship it!", to avoid unnecessary uploads to jira and review request.
> > - Also, close the review request as submitted once the patch is committed sothat it does not sit in to be reviewed queue.
Points noted. Thanks for the suggestions.
I have made few changes in the styling. Will update the patch for a quick re-review.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34041/#review83352
-----------------------------------------------------------
On May 11, 2015, 2:41 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34041/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 2:41 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Remove no-prefix and -p0 from contribute doc
>
>
> Diffs
> -----
>
> src/site/apt/developer/contribute.apt 821ddab
>
> Diff: https://reviews.apache.org/r/34041/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34041: LENS-548 : Remove no-prefix and -p0 from
contribute doc
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34041/#review83352
-----------------------------------------------------------
Ship it!
Please test the document by running mvn site:run and checkinf http://localhost:8080 - as documented here - http://lens.incubator.apache.org/developer/contribute.html#How_to_update_documentation
Yash,
Few suggestions for the review request :
- Can you link bugs field when you raise a review request? That will allow to click on the link and look at the bug if more details need to be looked up.
- We are following uploading the patch to jira ofter final "ship it!", to avoid unnecessary uploads to jira and review request.
- Also, close the review request as submitted once the patch is committed sothat it does not sit in to be reviewed queue.
- Amareshwari Sriramadasu
On May 11, 2015, 2:41 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34041/
> -----------------------------------------------------------
>
> (Updated May 11, 2015, 2:41 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Remove no-prefix and -p0 from contribute doc
>
>
> Diffs
> -----
>
> src/site/apt/developer/contribute.apt 821ddab
>
> Diff: https://reviews.apache.org/r/34041/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34041: LENS-548 : Remove no-prefix and -p0 from
contribute doc
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34041/#review83560
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On May 12, 2015, 11:36 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34041/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 11:36 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Remove no-prefix and -p0 from contribute doc
>
> Jira: https://issues.apache.org/jira/browse/LENS-548
>
>
> Diffs
> -----
>
> src/site/apt/developer/contribute.apt 821ddab
>
> Diff: https://reviews.apache.org/r/34041/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 34041: LENS-548 : Remove no-prefix and -p0 from
contribute doc
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34041/
-----------------------------------------------------------
(Updated May 12, 2015, 11:36 a.m.)
Review request for lens.
Changes
-------
Applied styling to git apply command.
Repository: lens
Description (updated)
-------
Remove no-prefix and -p0 from contribute doc
Jira: https://issues.apache.org/jira/browse/LENS-548
Diffs (updated)
-----
src/site/apt/developer/contribute.apt 821ddab
Diff: https://reviews.apache.org/r/34041/diff/
Testing
-------
Thanks,
Yash Sharma