You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ddna1021 <gi...@git.apache.org> on 2017/08/04 14:53:26 UTC
[GitHub] spark pull request #18845: Update StreamExecution.scala
GitHub user ddna1021 opened a pull request:
https://github.com/apache/spark/pull/18845
Update StreamExecution.scala
link to https://issues.apache.org/jira/browse/SPARK-21596
## What changes were proposed in this pull request?
class OffsetSeqLog is subclass of HDFSMetadataLog，so it should ensure places calling OffsetSeqLog.get check the return value also.
## How was this patch tested?
jenkins
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddna1021/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18845.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18845
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18845
@ddna1021 Thanks for working on this. The PR is created days ago and looks more comprehensive. So I'd suggest we go with that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18845
Ok. But there is already a PR created #18799.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: Update StreamExecution.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18845
I'm not clear how this relates to the JIRA. You are just changing an error message. Does this occur in practice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18845: [SPARK-21596] Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 closed the pull request at:
https://github.com/apache/spark/pull/18845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: Update StreamExecution.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18845
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18845: [SPARK-21596] Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 closed the pull request at:
https://github.com/apache/spark/pull/18845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 commented on the issue:
https://github.com/apache/spark/pull/18845
[SPARK-21596] means we must check the return value HDFSMetadataLog.get(), so it should ensure all the places taht calling the get() method of subclass of HDFSMetadataLog check the return value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18845: [SPARK-21596] Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
GitHub user ddna1021 reopened a pull request:
https://github.com/apache/spark/pull/18845
[SPARK-21596] Update StreamExecution.scala
[SPARK-21596]
link to https://issues.apache.org/jira/browse/SPARK-21596
## What changes were proposed in this pull request?
class OffsetSeqLog is subclass of HDFSMetadataLog，so it should ensure places calling OffsetSeqLog.get check the return value also.
## How was this patch tested?
jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddna1021/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18845.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18845
----
commit add573d36c11ad381a9c3beae7c8021efcbd2968
Author: FanDonglai <dd...@163.com>
Date: 2017-08-04T14:15:17Z
Update StreamExecution.scala
https://issues.apache.org/jira/browse/SPARK-21596
class OffsetSeqLog is subclass of HDFSMetadataLog，so it should ensure places calling OffsetSeqLog.get check the return value also.
commit 9b6fb4fd7eaf3835949504fe97734a07378a7027
Author: FanDonglai <dd...@163.com>
Date: 2017-08-04T15:16:47Z
Merge branch 'master' into master
commit 25a4140bbb1da1cf79211bdac5283aed75145f57
Author: FanDonglai <dd...@163.com>
Date: 2017-08-04T15:52:11Z
Update StreamExecution.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 commented on the issue:
https://github.com/apache/spark/pull/18845
[SPARK-21596] means we must check the return value HDFSMetadataLog.get(), so it should ensure all the places taht calling the get() method of subclass of HDFSMetadataLog check the return value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18845
Please close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: Update StreamExecution.scala
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18845
Is any chance you link to wrong JIRA?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 commented on the issue:
https://github.com/apache/spark/pull/18845
Should I close my PR，Sorry，I am a rookie
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18845
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18845: [SPARK-21596] Update StreamExecution.scala
Posted by ddna1021 <gi...@git.apache.org>.
Github user ddna1021 commented on the issue:
https://github.com/apache/spark/pull/18845
Ok,that menas my PR is invalid？
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org